telemetry/telemetry/internal/browser/browser_unittest.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/browser/browser_unittest.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/browser/browser_options.py ('k') | telemetry/telemetry/internal/browser/extension_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/browser/browser_unittest.py

diff --git a/telemetry/telemetry/internal/browser/browser_unittest.py b/telemetry/telemetry/internal/browser/browser_unittest.py

index fdfebbfa6f621972ca8d9db611fa157ba0ee840e..3ad5cf1edac71a962bb9ee61b0421d1d85340e72 100644

--- a/telemetry/telemetry/internal/browser/browser_unittest.py

+++ b/telemetry/telemetry/internal/browser/browser_unittest.py

@@ -170,7 +170,7 @@ def _GenerateBrowserProfile(number_of_tabs):

"""

profile_dir = tempfile.mkdtemp()

options = options_for_unittests.GetCopy()

- options.output_profile_path = profile_dir

+ options.browser_options.output_profile_path = profile_dir

browser_to_create = browser_finder.FindBrowser(options)

with browser_to_create.Create(options) as browser:

browser.platform.SetHTTPServerDirectories(path.GetUnittestDataDir())