telemetry/telemetry/page/shared_page_state.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: telemetry/telemetry/page/shared_page_state.py

diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py

index 454a08794304a9a2e2eb19fc0588dc1acc00940a..68afb1ddb7e48c95b02e6d7131a5d1f4e11ec923 100644

--- a/telemetry/telemetry/page/shared_page_state.py

+++ b/telemetry/telemetry/page/shared_page_state.py

@@ -395,11 +395,11 @@ class SharedPageState(story.SharedState):

"""

# Save the current input and output profiles.

saved_input_profile = finder_options.browser_options.profile_dir

- saved_output_profile = finder_options.output_profile_path

+ saved_output_profile = finder_options.browser_options.output_profile_path

# Set the input and output profiles.

finder_options.browser_options.profile_dir = initial_profile

- finder_options.output_profile_path = final_profile

+ finder_options.browser_options.output_profile_path = final_profile

# Launch the browser, then close it.

browser = found_browser.Create(finder_options)

@@ -407,7 +407,7 @@ class SharedPageState(story.SharedState):

# Load the saved input and output profiles.

finder_options.browser_options.profile_dir = saved_input_profile

- finder_options.output_profile_path = saved_output_profile

+ finder_options.browser_options.output_profile_path = saved_output_profile

def _MigratePregeneratedProfile(self):

"""Migrates the pre-generated profile by launching Chrome with it.

« no previous file with comments | « telemetry/telemetry/internal/browser/possible_browser.py ('k') | no next file » | no next file with comments »