Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
index 18713d95793f3b14ce2e212758c9a14fb4299c0f..c031bcf970892f5ee3f0c6f041cc3b0c632cf714 100644
--- a/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
@@ -14,13 +14,11 @@ from telemetry.internal import forwarders
class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
- def __init__(self, cros_platform_backend, browser_options, cri, is_guest,
- extensions_to_load):
+ def __init__(self, cros_platform_backend, browser_options, cri, is_guest):
super(CrOSBrowserBackend, self).__init__(
cros_platform_backend, supports_tab_control=True,
supports_extensions=not is_guest,
- browser_options=browser_options,
- output_profile_path=None, extensions_to_load=extensions_to_load)
+ browser_options=browser_options)
assert browser_options.IsCrosBrowserOptions()
# Initialize fields so that an explosion during init doesn't break in Close.
self._cri = cri
@@ -29,6 +27,8 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
self._remote_debugging_port = self._cri.GetRemotePort()
self._port = self._remote_debugging_port
+ extensions_to_load = browser_options.extensions_to_load
+
# Copy extensions to temp directories on the device.
# Note that we also perform this copy locally to ensure that
# the owner of the extensions is set to chronos.

Powered by Google App Engine
This is Rietveld 408576698