Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
diff --git a/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py b/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
index 0db44f1e2e7e8c99564d0dfff53d6ad7a1621d4b..b93c647565a2b179a185efa59c212abf2b215fcf 100644
--- a/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
+++ b/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
@@ -63,14 +63,13 @@ class PossibleDesktopBrowser(possible_browser.PossibleBrowser):
browser_backend = desktop_browser_backend.DesktopBrowserBackend(
self._platform_backend,
finder_options.browser_options, self._local_executable,
- self._flash_path, self._is_content_shell, self._browser_directory,
- output_profile_path=finder_options.output_profile_path,
- extensions_to_load=finder_options.extensions_to_load)
+ self._flash_path, self._is_content_shell, self._browser_directory)
return browser.Browser(
browser_backend, self._platform_backend, self._credentials_path)
- def SupportsOptions(self, finder_options):
- if (len(finder_options.extensions_to_load) != 0) and self._is_content_shell:
+ def SupportsOptions(self, browser_options):
+ if ((len(browser_options.extensions_to_load) != 0)
+ and self._is_content_shell):
return False
return True

Powered by Google App Engine
This is Rietveld 408576698