telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/android_browser_finder.py ('k') | telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

index 06acf3a2f2de0e8fb0f3cdc074eb6314551324c7..c3f35ea8ffe68a3c39fceafd84533b72f4715ad1 100644

--- a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py

@@ -26,8 +26,7 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

# It is OK to have abstract methods. pylint: disable=abstract-method

def __init__(self, platform_backend, supports_tab_control,

- supports_extensions, browser_options, output_profile_path,

- extensions_to_load):

+ supports_extensions, browser_options):

super(ChromeBrowserBackend, self).__init__(

platform_backend=platform_backend,

supports_extensions=supports_extensions,

@@ -39,8 +38,8 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

self._devtools_client = None

self._system_info_backend = None

- self._output_profile_path = output_profile_path

- self._extensions_to_load = extensions_to_load

+ self._output_profile_path = browser_options.output_profile_path

+ self._extensions_to_load = browser_options.extensions_to_load

if (self.browser_options.dont_override_profile and

not options_for_unittests.AreSet()):