telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py ('k') | telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py

diff --git a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py

index 52ad12c54aa997868c9c4994a8bb4baad6118b91..515e6f221d9b4421986df3602a98517730c61780 100644

--- a/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py

+++ b/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py

@@ -46,15 +46,15 @@ class TestChromeBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

def __init__(self, browser_options,

wpr_http_device_port=None, wpr_https_device_port=None,

is_running_locally=False):

+ browser_options.extensions_to_load = []

+ browser_options.output_profile_path = None

super(TestChromeBrowserBackend, self).__init__(

platform_backend=FakePlatformBackend(

browser_options.wpr_mode != wpr_modes.WPR_OFF,

wpr_http_device_port, wpr_https_device_port, is_running_locally),

supports_tab_control=False,

supports_extensions=False,

- browser_options=browser_options,

- output_profile_path=None,

- extensions_to_load=[])

+ browser_options=browser_options)

class StartupArgsTest(unittest.TestCase):