telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py ('k') | telemetry/telemetry/internal/browser/browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

diff --git a/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py b/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

index 319c2c34cee0eb47aee45da16120ab323cc7b4d0..c4e98f317b00569cef0a253441330ec46ea127e8 100644

--- a/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

+++ b/telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py

@@ -36,7 +36,7 @@ class PossibleIOSBrowser(possible_browser.PossibleBrowser):

return browser.Browser(

browser_backend, self._platform_backend, self._credentials_path)

- def SupportsOptions(self, finder_options):

+ def SupportsOptions(self, browser_options):

#TODO(baxley): Implement me.

return True