telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py ('k') | telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

diff --git a/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

index 1c193f0b999ecf67edb869f42ab7600f89d65a21..69d5c1f8c6319c4aeb2bfcb81d1270a3237542ea 100644

--- a/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

+++ b/telemetry/telemetry/internal/backends/chrome/ios_browser_backend.py

@@ -20,13 +20,12 @@ class IosBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

_DEVICE_LIST_URL = 'http://localhost:9221/json'

def __init__(self, ios_platform_backend, browser_options):

+ browser_options.output_profile_path = '.'

super(IosBrowserBackend, self).__init__(

ios_platform_backend,

supports_tab_control=False,

supports_extensions=False,

- browser_options=browser_options,

- output_profile_path=".",

- extensions_to_load=None)

+ browser_options=browser_options)

self._webviews = []

self._port = None

self._page = None