telemetry/telemetry/internal/browser/browser_finder.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/browser/browser_finder.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome/ios_browser_finder.py ('k') | telemetry/telemetry/internal/browser/browser_options.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/browser/browser_finder.py

diff --git a/telemetry/telemetry/internal/browser/browser_finder.py b/telemetry/telemetry/internal/browser/browser_finder.py

index 92e5accfe146964666ba9ac06da24c010b629735..242f491e96fbc21d75476b3f84dfe1dcff219167 100644

--- a/telemetry/telemetry/internal/browser/browser_finder.py

+++ b/telemetry/telemetry/internal/browser/browser_finder.py

@@ -107,7 +107,8 @@ def FindBrowser(options):

return None

matching_browsers = [b for b in browsers

- if b.browser_type == options.browser_type and b.SupportsOptions(options)]

+ if b.browser_type == options.browser_type and

+ b.SupportsOptions(options.browser_options)]

chosen_browser = None

if len(matching_browsers) == 1: