telemetry/telemetry/internal/browser/extension_unittest.py - Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/browser/extension_unittest.py

Issue 1874473006: [Telemetry] Move extensions_to_load and output_profile_path into browser_options (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/browser/browser_unittest.py ('k') | telemetry/telemetry/internal/browser/possible_browser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/browser/extension_unittest.py

diff --git a/telemetry/telemetry/internal/browser/extension_unittest.py b/telemetry/telemetry/internal/browser/extension_unittest.py

index 02442b162045cdb43249bf4e752ac6f7be9f6f70..2325b1440e48821e65883d1c88bf2d287a0965e3 100644

--- a/telemetry/telemetry/internal/browser/extension_unittest.py

+++ b/telemetry/telemetry/internal/browser/extension_unittest.py

@@ -26,7 +26,7 @@ class ExtensionTest(unittest.TestCase):

options = options_for_unittests.GetCopy()

load_extension = extension_to_load.ExtensionToLoad(

extension_path, options.browser_type)

- options.extensions_to_load = [load_extension]

+ options.browser_options.extensions_to_load = [load_extension]

browser_to_create = browser_finder.FindBrowser(options)

if not browser_to_create:

@@ -118,7 +118,7 @@ class MultipleExtensionTest(unittest.TestCase):

self._extensions_to_load = [extension_to_load.ExtensionToLoad(

d, options.browser_type)

for d in self._extension_dirs]

- options.extensions_to_load = self._extensions_to_load

+ options.browser_options.extensions_to_load = self._extensions_to_load

browser_to_create = browser_finder.FindBrowser(options)

self._browser = None

# May not find a browser that supports extensions.

@@ -158,7 +158,7 @@ class ComponentExtensionTest(unittest.TestCase):

load_extension = extension_to_load.ExtensionToLoad(

extension_path, options.browser_type, is_component=True)

- options.extensions_to_load = [load_extension]

+ options.browser_options.extensions_to_load = [load_extension]

browser_to_create = browser_finder.FindBrowser(options)

if not browser_to_create:

logging.warning('Did not find a browser that supports extensions, '