Convert //tools to use std::unique_ptr

Convert //tools to use std::unique_ptr

BUG=554298
Committed: https://crrev.com/a500b69aa06c2bc084a3b1867b9824f4218014de
Cr-Commit-Position: refs/heads/master@{#386168}

[dcheng, 2016-04-06 20:51:19]

dcheng@chromium.org changed reviewers:
+ brettw@chromium.org, lizeb@chromium.org, michaelbai@chromium.org,
nednguyen@google.com, rdevlin.cronin@chromium.org, vmpstr@chromium.org

[dcheng, 2016-04-06 20:53:37]

dcheng@chromium.org changed reviewers:
+ inferno@chromium.org

[dcheng, 2016-04-06 20:57:27]

dcheng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dcheng, 2016-04-06 20:58:05]

+brettw for //tools/gn and //tools/imagediff (which has no direct OWNER)
+dmazzoni for //ui
+inferno for //tools/ipc_fuzzer
+lizeb for //tools/cygprofile
+michaelbai for //tools/android
+nednguyen for //tools/battor_agent
+rdevlin.cronin for //chrome/browser/extensions, //extensions, and
//tools/json_schema_compiler

https://codereview.chromium.org/1869503004/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/developer_private/extension_info_generator.h
(right):

https://codereview.chromium.org/1869503004/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/developer_private/extension_info_generator.h:12:
#include "base/memory/scoped_ptr.h"
IWYU for extension API implementations that forgot to include it themselves.

https://codereview.chromium.org/1869503004/diff/1/ui/accessibility/ax_node_da...
File ui/accessibility/ax_node_data.h (right):

https://codereview.chromium.org/1869503004/diff/1/ui/accessibility/ax_node_da...
ui/accessibility/ax_node_data.h:14: #include "base/memory/scoped_ptr.h"
I have no idea where this file was previously getting scoped_ptr.h from, but the
compile broke without it, and the class definition definitely uses it, so I
added it.

[nednguyen, 2016-04-06 21:04:24]

toosl/battor/ lgtm

[Devlin, 2016-04-06 21:08:51]

extensions lgtm

[vmpstr, 2016-04-06 21:12:29]

lgtm with optional comments

https://codereview.chromium.org/1869503004/diff/1/tools/android/forwarder2/da...
File tools/android/forwarder2/daemon.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/android/forwarder2/da...
tools/android/forwarder2/daemon.cc:126: return std::unique_ptr<Socket>();
This would probably look better as "return nullptr;"

https://codereview.chromium.org/1869503004/diff/1/tools/gn/functions_unittest.cc
File tools/gn/functions_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/gn/functions_unittest...
tools/gn/functions_unittest.cc:51: std::unique_ptr<IdentifierNode>(new
IdentifierNode(undefined_token)));
This can be WrapUnique, but this is fine as well.

https://codereview.chromium.org/1869503004/diff/1/tools/gn/template.cc
File tools/gn/template.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/gn/template.cc#newcode81
tools/gn/template.cc:81: template_scope.SetValue(kInvoker, Value(nullptr,
std::unique_ptr<Scope>()),
This can also be nullptr I think

[michaelbai, 2016-04-06 21:24:49]

michaelbai@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[michaelbai, 2016-04-06 21:24:50]

+wangxianzhu for tools/android

[dcheng, 2016-04-06 21:26:33]

https://codereview.chromium.org/1869503004/diff/1/tools/android/forwarder2/da...
File tools/android/forwarder2/daemon.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/android/forwarder2/da...
tools/android/forwarder2/daemon.cc:126: return std::unique_ptr<Socket>();
On 2016/04/06 at 21:12:29, vmpstr wrote:
> This would probably look better as "return nullptr;"

Done. Given the amount of things left to convert (60000+ references), any
cleanup that happens is purely incidental. It's definitely not a primary goal =)

https://codereview.chromium.org/1869503004/diff/1/tools/gn/functions_unittest.cc
File tools/gn/functions_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/gn/functions_unittest...
tools/gn/functions_unittest.cc:51: std::unique_ptr<IdentifierNode>(new
IdentifierNode(undefined_token)));
On 2016/04/06 at 21:12:29, vmpstr wrote:
> This can be WrapUnique, but this is fine as well.

Done.

https://codereview.chromium.org/1869503004/diff/1/tools/gn/template.cc
File tools/gn/template.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/gn/template.cc#newcode81
tools/gn/template.cc:81: template_scope.SetValue(kInvoker, Value(nullptr,
std::unique_ptr<Scope>()),
On 2016/04/06 at 21:12:29, vmpstr wrote:
> This can also be nullptr I think

Done.

[vmpstr, 2016-04-06 21:28:28]

https://codereview.chromium.org/1869503004/diff/1/tools/android/forwarder2/da...
File tools/android/forwarder2/daemon.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/android/forwarder2/da...
tools/android/forwarder2/daemon.cc:126: return std::unique_ptr<Socket>();
On 2016/04/06 21:26:32, dcheng wrote:
> On 2016/04/06 at 21:12:29, vmpstr wrote:
> > This would probably look better as "return nullptr;"
> 
> Done. Given the amount of things left to convert (60000+ references), any
> cleanup that happens is purely incidental. It's definitely not a primary goal
=)

Understood :) I considered not commenting, since a lot of this is probably going
to end up being s/scoped_ptr/std::unique_ptr/g but I just couldn't resist.

[dcheng, 2016-04-06 22:35:09]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 22:36:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869503004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869503004/20001

[commit-bot: I haz the power, 2016-04-06 22:53:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 22:53:10]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[dmazzoni, 2016-04-06 23:04:25]

lgtm

[Xianzhu, 2016-04-06 23:16:54]

tools/android lgtm

[dcheng, 2016-04-07 00:53:05]

https://codereview.chromium.org/1869503004/diff/1/tools/gn/template.cc
File tools/gn/template.cc (right):

https://codereview.chromium.org/1869503004/diff/1/tools/gn/template.cc#newcode81
tools/gn/template.cc:81: template_scope.SetValue(kInvoker, Value(nullptr,
std::unique_ptr<Scope>()),
On 2016/04/06 at 21:26:32, dcheng wrote:
> On 2016/04/06 at 21:12:29, vmpstr wrote:
> > This can also be nullptr I think
> 
> Done.

As it turns out, this actually doesn't work due to these constructors here
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/value.h&l=36:
  Value(const ParseNode* origin, const char* str_val);
  Value(const ParseNode* origin, scoped_ptr<Scope> scope);

[dcheng, 2016-04-07 01:01:32]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 01:02:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869503004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869503004/40001

[commit-bot: I haz the power, 2016-04-07 03:20:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 03:20:43]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-04-07 04:15:59]

missed that I was also for json_schema_compiler.

s lgtm with totally optional nits (since none of these are issues from your
patch).

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/additional_properties_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/additional_properties_unittest.cc:5: #include
"testing/gtest/include/gtest/gtest.h"
nit: maybe fix IWYU error here and in the other test files?

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/arrays_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/arrays_unittest.cc:22: base::DictionaryValue*
value = new base::DictionaryValue();
If you're here anyway, maybe change this to create a std::unique_ptr here and
return it directly rather than WrapUnique?

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/crossref_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/crossref_unittest.cc:18: base::DictionaryValue*
value(new base::DictionaryValue());
here too

[dcheng, 2016-04-07 04:24:03]

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/additional_properties_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/additional_properties_unittest.cc:5: #include
"testing/gtest/include/gtest/gtest.h"
On 2016/04/07 at 04:15:59, Devlin wrote:
> nit: maybe fix IWYU error here and in the other test files?

Done.

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/arrays_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/arrays_unittest.cc:22: base::DictionaryValue*
value = new base::DictionaryValue();
On 2016/04/07 at 04:15:59, Devlin wrote:
> If you're here anyway, maybe change this to create a std::unique_ptr here and
return it directly rather than WrapUnique?

Done.

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
File tools/json_schema_compiler/test/crossref_unittest.cc (right):

https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
tools/json_schema_compiler/test/crossref_unittest.cc:18: base::DictionaryValue*
value(new base::DictionaryValue());
On 2016/04/07 at 04:15:59, Devlin wrote:
> here too

Done.

[Benoit L, 2016-04-07 08:14:15]

On 2016/04/07 04:24:03, dcheng wrote:
>
https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
> File tools/json_schema_compiler/test/additional_properties_unittest.cc
(right):
> 
>
https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
> tools/json_schema_compiler/test/additional_properties_unittest.cc:5: #include
> "testing/gtest/include/gtest/gtest.h"
> On 2016/04/07 at 04:15:59, Devlin wrote:
> > nit: maybe fix IWYU error here and in the other test files?
> 
> Done.
> 
>
https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
> File tools/json_schema_compiler/test/arrays_unittest.cc (right):
> 
>
https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
> tools/json_schema_compiler/test/arrays_unittest.cc:22: base::DictionaryValue*
> value = new base::DictionaryValue();
> On 2016/04/07 at 04:15:59, Devlin wrote:
> > If you're here anyway, maybe change this to create a std::unique_ptr here
and
> return it directly rather than WrapUnique?
> 
> Done.
> 
>
https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
> File tools/json_schema_compiler/test/crossref_unittest.cc (right):
> 
>
https://codereview.chromium.org/1869503004/diff/40001/tools/json_schema_compi...
> tools/json_schema_compiler/test/crossref_unittest.cc:18:
base::DictionaryValue*
> value(new base::DictionaryValue());
> On 2016/04/07 at 04:15:59, Devlin wrote:
> > here too
> 
> Done.

tools/cygprofile lgtm

[brettw, 2016-04-08 18:07:10]

lgtm

[Martin Barbella, 2016-04-08 18:19:26]

mbarbella@chromium.org changed reviewers:
+ mbarbella@chromium.org

[Martin Barbella, 2016-04-08 18:19:28]

tools/ipc_fuzzer lgtm.

[dcheng, 2016-04-08 18:32:00]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-08 18:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org,
nednguyen@google.com, dmazzoni@chromium.org, wangxianzhu@chromium.org,
rdevlin.cronin@chromium.org, lizeb@chromium.org, mbarbella@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1869503004/#ps80001
(title: "rebase, change iwyu fixes for converted directories to include
<memory>")

[commit-bot: I haz the power, 2016-04-08 18:33:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869503004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869503004/80001

[commit-bot: I haz the power, 2016-04-08 19:55:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-08 19:59:26]

Description was changed from

==========
Convert //tools to use std::unique_ptr

BUG=554298
==========

to

==========
Convert //tools to use std::unique_ptr

BUG=554298

Committed: https://crrev.com/a500b69aa06c2bc084a3b1867b9824f4218014de
Cr-Commit-Position: refs/heads/master@{#386168}
==========

[commit-bot: I haz the power, 2016-04-08 19:59:27]

Patchset 5 (id:??) landed as
https://crrev.com/a500b69aa06c2bc084a3b1867b9824f4218014de
Cr-Commit-Position: refs/heads/master@{#386168}