tools/gn/target_unittest.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target_unittest.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target_unittest.cc

diff --git a/tools/gn/target_unittest.cc b/tools/gn/target_unittest.cc

index 8629ff21d39db2628ecfb756e7d590d558656472..e2e41a8708cd2e182a173f846bd50901ac4b0aba 100644

--- a/tools/gn/target_unittest.cc

+++ b/tools/gn/target_unittest.cc

@@ -431,7 +431,7 @@ TEST(Target, LinkAndDepOutputs) {

Toolchain toolchain(setup.settings(), Label(SourceDir("//tc/"), "tc"));

- scoped_ptr<Tool> solink_tool(new Tool());

+ std::unique_ptr<Tool> solink_tool(new Tool());

solink_tool->set_output_prefix("lib");

solink_tool->set_default_output_extension(".so");

@@ -470,7 +470,7 @@ TEST(Target, RuntimeLinkOuput) {

Toolchain toolchain(setup.settings(), Label(SourceDir("//tc/"), "tc"));

- scoped_ptr<Tool> solink_tool(new Tool());

+ std::unique_ptr<Tool> solink_tool(new Tool());

solink_tool->set_output_prefix("");

solink_tool->set_default_output_extension(".dll");

« no previous file with comments | « tools/gn/target_generator.cc ('k') | tools/gn/template.h » ('j') | no next file with comments »