Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: tools/gn/builder_record.h

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/builder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/builder_record.h
diff --git a/tools/gn/builder_record.h b/tools/gn/builder_record.h
index 469b1cffd3c5cb57cfc356f56413448c069174c6..a767c9b103b67eb4018b4db9a65d862d9e3430a3 100644
--- a/tools/gn/builder_record.h
+++ b/tools/gn/builder_record.h
@@ -5,11 +5,11 @@
#ifndef TOOLS_GN_BUILDER_RECORD_H_
#define TOOLS_GN_BUILDER_RECORD_H_
+#include <memory>
#include <set>
#include <utility>
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "tools/gn/item.h"
#include "tools/gn/location.h"
@@ -55,7 +55,7 @@ class BuilderRecord {
Item* item() { return item_.get(); }
const Item* item() const { return item_.get(); }
- void set_item(scoped_ptr<Item> item) { item_ = std::move(item); }
+ void set_item(std::unique_ptr<Item> item) { item_ = std::move(item); }
// Indicates from where this item was originally referenced from that caused
// it to be loaded. For targets for which we encountered the declaration
@@ -97,7 +97,7 @@ class BuilderRecord {
private:
ItemType type_;
Label label_;
- scoped_ptr<Item> item_;
+ std::unique_ptr<Item> item_;
const ParseNode* originally_referenced_from_;
bool should_generate_;
bool resolved_;
« no previous file with comments | « tools/gn/builder.cc ('k') | tools/gn/builder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698