Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tools/gn/input_file_manager.h

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/input_conversion.cc ('k') | tools/gn/input_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/input_file_manager.h
diff --git a/tools/gn/input_file_manager.h b/tools/gn/input_file_manager.h
index 38ff37e721132511f33dae430f4a5306ffb6c41f..ba055e219c57bbc18ce2943ffcdd14491fec9b0c 100644
--- a/tools/gn/input_file_manager.h
+++ b/tools/gn/input_file_manager.h
@@ -82,7 +82,7 @@ class InputFileManager : public base::RefCountedThreadSafe<InputFileManager> {
void AddDynamicInput(const SourceFile& name,
InputFile** file,
std::vector<Token>** tokens,
- scoped_ptr<ParseNode>** parse_root);
+ std::unique_ptr<ParseNode>** parse_root);
// Does not count dynamic input.
int GetInputFileCount() const;
@@ -111,12 +111,12 @@ class InputFileManager : public base::RefCountedThreadSafe<InputFileManager> {
// Event to signal when the load is complete (or fails). This is lazily
// created only when a thread is synchronously waiting for this load (which
// only happens for imports).
- scoped_ptr<base::WaitableEvent> completion_event;
+ std::unique_ptr<base::WaitableEvent> completion_event;
std::vector<Token> tokens;
// Null before the file is loaded or if loading failed.
- scoped_ptr<ParseNode> parsed_root;
+ std::unique_ptr<ParseNode> parsed_root;
Err parse_error;
};
« no previous file with comments | « tools/gn/input_conversion.cc ('k') | tools/gn/input_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698