tools/gn/build_settings.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/build_settings.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/build_settings.cc

diff --git a/tools/gn/build_settings.cc b/tools/gn/build_settings.cc

index 72a74c33122bde275c00635924545cc573579ead..14f1aa8697b393334c326d594cc0c2693fa3e21d 100644

--- a/tools/gn/build_settings.cc

+++ b/tools/gn/build_settings.cc

@@ -59,7 +59,7 @@ base::FilePath BuildSettings::GetFullPathSecondary(

return dir.Resolve(secondary_source_path_).NormalizePathSeparatorsTo('/');

}

-void BuildSettings::ItemDefined(scoped_ptr<Item> item) const {

+void BuildSettings::ItemDefined(std::unique_ptr<Item> item) const {

DCHECK(item);

if (!item_defined_callback_.is_null())

item_defined_callback_.Run(std::move(item));

« no previous file with comments | « tools/gn/build_settings.h ('k') | tools/gn/builder.h » ('j') | no next file with comments »