tools/gn/command_format.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_format.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_format.cc

diff --git a/tools/gn/command_format.cc b/tools/gn/command_format.cc

index ae36e37783e8792a0ced125f4b6b783ad8b3eab4..a054b21b9b9cef6aadd8877356036a1ef8da9e32 100644

--- a/tools/gn/command_format.cc

+++ b/tools/gn/command_format.cc

@@ -982,7 +982,7 @@ bool FormatStringToString(const std::string& input,

}

// Parse.

- scoped_ptr<ParseNode> parse_node = Parser::Parse(tokens, &err);

+ std::unique_ptr<ParseNode> parse_node = Parser::Parse(tokens, &err);

if (err.has_error()) {

err.PrintToStdout();

return false;

« no previous file with comments | « tools/gn/builder_unittest.cc ('k') | tools/gn/eclipse_writer.cc » ('j') | no next file with comments »