tools/json_schema_compiler/util_cc_helper.py - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/util_cc_helper.py

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/util_cc_helper.py

diff --git a/tools/json_schema_compiler/util_cc_helper.py b/tools/json_schema_compiler/util_cc_helper.py

index d69122dfc38cb1baba864f64d56c1735aceacb4c..e81c4e359435fada0abc6e481300a8ebc5fb7399 100644

--- a/tools/json_schema_compiler/util_cc_helper.py

+++ b/tools/json_schema_compiler/util_cc_helper.py

@@ -22,7 +22,7 @@ class UtilCCHelper(object):

def CreateValueFromArray(self, src, optional):

"""Generates code to create a scoped_pt<Value> from the array at src.

- |src| The variable to convert, either a vector or scoped_ptr<vector>.

+ |src| The variable to convert, either a vector or std::unique_ptr<vector>.

|optional| Whether |type_| was optional. Optional types are pointers so

must be treated differently.

"""

« no previous file with comments | « tools/json_schema_compiler/util.cc ('k') | ui/accessibility/ax_node_data.h » ('j') | no next file with comments »