tools/gn/scope_unittest.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/scope_unittest.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/scope_unittest.cc

diff --git a/tools/gn/scope_unittest.cc b/tools/gn/scope_unittest.cc

index ce79973c54edba9e191a5422b5a9b76ca5a471c0..de2005a5144e8e19f903568ed8957807acf1aeda 100644

--- a/tools/gn/scope_unittest.cc

+++ b/tools/gn/scope_unittest.cc

@@ -217,7 +217,7 @@ TEST(Scope, MakeClosure) {

nested2.SetValue("on_two", Value(&assignment, "on_two2"), &assignment);

// Making a closure from the root scope.

- scoped_ptr<Scope> result = setup.scope()->MakeClosure();

+ std::unique_ptr<Scope> result = setup.scope()->MakeClosure();

EXPECT_FALSE(result->containing()); // Should have no containing scope.

EXPECT_TRUE(result->GetValue("on_root")); // Value should be copied.

« no previous file with comments | « tools/gn/scope_per_file_provider.h ('k') | tools/gn/setup.h » ('j') | no next file with comments »