Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: tools/gn/ninja_binary_target_writer_unittest.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/loader_unittest.cc ('k') | tools/gn/operators_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer_unittest.cc
diff --git a/tools/gn/ninja_binary_target_writer_unittest.cc b/tools/gn/ninja_binary_target_writer_unittest.cc
index 0b878830474db1f706d098246ebdaa93b80d963f..1e02446dfe3758954c3e9061232ca599fc998274 100644
--- a/tools/gn/ninja_binary_target_writer_unittest.cc
+++ b/tools/gn/ninja_binary_target_writer_unittest.cc
@@ -476,7 +476,7 @@ TEST(NinjaBinaryTargetWriter, WinPrecompiledHeaders) {
pch_settings.set_default_toolchain_label(setup.toolchain()->label());
// Declare a C++ compiler that supports PCH.
- scoped_ptr<Tool> cxx_tool(new Tool);
+ std::unique_ptr<Tool> cxx_tool(new Tool);
TestWithScope::SetCommandForTool(
"c++ {{source}} {{cflags}} {{cflags_cc}} {{defines}} {{include_dirs}} "
"-o {{output}}",
@@ -487,7 +487,7 @@ TEST(NinjaBinaryTargetWriter, WinPrecompiledHeaders) {
pch_toolchain.SetTool(Toolchain::TYPE_CXX, std::move(cxx_tool));
// Add a C compiler as well.
- scoped_ptr<Tool> cc_tool(new Tool);
+ std::unique_ptr<Tool> cc_tool(new Tool);
TestWithScope::SetCommandForTool(
"cc {{source}} {{cflags}} {{cflags_c}} {{defines}} {{include_dirs}} "
"-o {{output}}",
@@ -604,7 +604,7 @@ TEST(NinjaBinaryTargetWriter, GCCPrecompiledHeaders) {
pch_settings.set_default_toolchain_label(setup.toolchain()->label());
// Declare a C++ compiler that supports PCH.
- scoped_ptr<Tool> cxx_tool(new Tool);
+ std::unique_ptr<Tool> cxx_tool(new Tool);
TestWithScope::SetCommandForTool(
"c++ {{source}} {{cflags}} {{cflags_cc}} {{defines}} {{include_dirs}} "
"-o {{output}}",
@@ -616,7 +616,7 @@ TEST(NinjaBinaryTargetWriter, GCCPrecompiledHeaders) {
pch_toolchain.ToolchainSetupComplete();
// Add a C compiler as well.
- scoped_ptr<Tool> cc_tool(new Tool);
+ std::unique_ptr<Tool> cc_tool(new Tool);
TestWithScope::SetCommandForTool(
"cc {{source}} {{cflags}} {{cflags_c}} {{defines}} {{include_dirs}} "
"-o {{output}}",
« no previous file with comments | « tools/gn/loader_unittest.cc ('k') | tools/gn/operators_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698