tools/json_schema_compiler/cpp_type_generator.py - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cpp_type_generator.py

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/json_schema_compiler/cpp_type_generator.py

diff --git a/tools/json_schema_compiler/cpp_type_generator.py b/tools/json_schema_compiler/cpp_type_generator.py

index 23460c63699c6a6a8845a2978794d5103585c475..269a99572c1453a789597dbbcf6b0b5dae01b79b 100644

--- a/tools/json_schema_compiler/cpp_type_generator.py

+++ b/tools/json_schema_compiler/cpp_type_generator.py

@@ -125,7 +125,7 @@ class CppTypeGenerator(object):

# Wrap ptrs and base::Values in containers (which aren't movable) in

# scoped_ptrs.

if is_ptr or (is_in_container and is_base_value):

- cpp_type = 'scoped_ptr<%s>' % cpp_util.PadForGenerics(cpp_type)

+ cpp_type = 'std::unique_ptr<%s>' % cpp_util.PadForGenerics(cpp_type)

return cpp_type