tools/gn/import_manager.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/import_manager.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/import_manager.cc

diff --git a/tools/gn/import_manager.cc b/tools/gn/import_manager.cc

index 2d39846d981b89d99efa50eb8989cfd14b17f676..83cc09020cdafb020462b8ece9a6ff3e9f6330dd 100644

--- a/tools/gn/import_manager.cc

+++ b/tools/gn/import_manager.cc

@@ -4,7 +4,8 @@

#include "tools/gn/import_manager.h"

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "base/stl_util.h"

#include "tools/gn/parse_tree.h"

#include "tools/gn/scheduler.h"

@@ -22,7 +23,7 @@ Scope* UncachedImport(const Settings* settings,

if (!node)

return nullptr;

- scoped_ptr<Scope> scope(new Scope(settings->base_config()));

+ std::unique_ptr<Scope> scope(new Scope(settings->base_config()));

scope->set_source_dir(file.GetDir());

// Don't allow ScopePerFileProvider to provide target-related variables.

« no previous file with comments | « tools/gn/header_checker.cc ('k') | tools/gn/input_conversion.cc » ('j') | no next file with comments »