tools/gn/toolchain.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/toolchain.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/toolchain.cc

diff --git a/tools/gn/toolchain.cc b/tools/gn/toolchain.cc

index 280fb12d6f2a734e225897a15605f86e4c4c8265..14d2bfd159590bb0775d5b081f2ebb42e8f5779e 100644

--- a/tools/gn/toolchain.cc

+++ b/tools/gn/toolchain.cc

@@ -91,7 +91,7 @@ const Tool* Toolchain::GetTool(ToolType type) const {

return tools_[static_cast<size_t>(type)].get();

}

-void Toolchain::SetTool(ToolType type, scoped_ptr<Tool> t) {

+void Toolchain::SetTool(ToolType type, std::unique_ptr<Tool> t) {

DCHECK(type != TYPE_NONE);

DCHECK(!tools_[type].get());

t->SetComplete();

« no previous file with comments | « tools/gn/toolchain.h ('k') | tools/gn/value.h » ('j') | no next file with comments »