chrome/browser/extensions/api/log_private/filter_handler.cc - Issue 1869503004: Convert //tools to use std::unique_ptr

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/log_private/filter_handler.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc ('k') | chrome/browser/extensions/extension_tab_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/api/log_private/filter_handler.h"	5 #include "chrome/browser/extensions/api/log_private/filter_handler.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

	8 #include <memory>

8 #include <string>	9 #include <string>

9 #include <vector>	10 #include <vector>

10	11

11 #include "chrome/common/extensions/api/log_private.h"	12 #include "chrome/common/extensions/api/log_private.h"

12	13

13 namespace extensions {	14 namespace extensions {

14	15

15 namespace {	16 namespace {

16	17

17 template <typename T>	18 template <typename T>

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50	51

51 bool FilterHandler::IsValidLevel(const std::string& level) const {	52 bool FilterHandler::IsValidLevel(const std::string& level) const {

52 return IsValidField(filter_.level, level);	53 return IsValidField(filter_.level, level);

53 }	54 }

54	55

55 bool FilterHandler::IsValidProcess(const std::string& process) const {	56 bool FilterHandler::IsValidProcess(const std::string& process) const {

56 return IsValidField(filter_.process, process);	57 return IsValidField(filter_.process, process);

57 }	58 }

58	59

59 } // namespace extensions	60 } // namespace extensions

OLD	NEW