Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: tools/gn/target_generator.cc

Issue 1869503004: Convert //tools to use std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, change iwyu fixes for converted directories to include <memory> Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/string_utils_unittest.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/target_generator.h" 5 #include "tools/gn/target_generator.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "tools/gn/action_target_generator.h" 9 #include "tools/gn/action_target_generator.h"
10 #include "tools/gn/binary_target_generator.h" 10 #include "tools/gn/binary_target_generator.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 // The location of the target is the directory name with no slash at the end. 82 // The location of the target is the directory name with no slash at the end.
83 // FIXME(brettw) validate name. 83 // FIXME(brettw) validate name.
84 const Label& toolchain_label = ToolchainLabelForScope(scope); 84 const Label& toolchain_label = ToolchainLabelForScope(scope);
85 Label label(scope->GetSourceDir(), args[0].string_value(), 85 Label label(scope->GetSourceDir(), args[0].string_value(),
86 toolchain_label.dir(), toolchain_label.name()); 86 toolchain_label.dir(), toolchain_label.name());
87 87
88 if (g_scheduler->verbose_logging()) 88 if (g_scheduler->verbose_logging())
89 g_scheduler->Log("Defining target", label.GetUserVisibleName(true)); 89 g_scheduler->Log("Defining target", label.GetUserVisibleName(true));
90 90
91 scoped_ptr<Target> target(new Target(scope->settings(), label)); 91 std::unique_ptr<Target> target(new Target(scope->settings(), label));
92 target->set_defined_from(function_call); 92 target->set_defined_from(function_call);
93 93
94 // Create and call out to the proper generator. 94 // Create and call out to the proper generator.
95 if (output_type == functions::kBundleData) { 95 if (output_type == functions::kBundleData) {
96 BundleDataTargetGenerator generator( 96 BundleDataTargetGenerator generator(
97 target.get(), scope, function_call, err); 97 target.get(), scope, function_call, err);
98 generator.Run(); 98 generator.Run();
99 } else if (output_type == functions::kCreateBundle) { 99 } else if (output_type == functions::kCreateBundle) {
100 CreateBundleTargetGenerator generator(target.get(), scope, function_call, 100 CreateBundleTargetGenerator generator(target.get(), scope, function_call,
101 err); 101 err);
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 return false; 399 return false;
400 if (!EnsureStringIsInOutputDir(GetBuildSettings()->build_dir(), 400 if (!EnsureStringIsInOutputDir(GetBuildSettings()->build_dir(),
401 source_file.value(), value->origin(), err_)) 401 source_file.value(), value->origin(), err_))
402 return false; 402 return false;
403 OutputFile output_file(GetBuildSettings(), source_file); 403 OutputFile output_file(GetBuildSettings(), source_file);
404 target_->set_write_runtime_deps_output(output_file); 404 target_->set_write_runtime_deps_output(output_file);
405 405
406 g_scheduler->AddWriteRuntimeDepsTarget(target_); 406 g_scheduler->AddWriteRuntimeDepsTarget(target_);
407 return true; 407 return true;
408 } 408 }
OLDNEW
« no previous file with comments | « tools/gn/string_utils_unittest.cc ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698