Review and cleanup lint warnings.

Review and cleanup lint warnings.

This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3ebd121d45ceb08918a3dcb5b3b7ac29448c862f

[dsinclair, 2016-03-07 19:35:59]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org

[dsinclair, 2016-03-07 19:36:00]

PTAL.

[dsinclair, 2016-03-08 01:15:59]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org
- thestig@chromium.org

[Tom Sepez, 2016-03-08 19:27:06]

Including <string> isn't the right fix for most of the string warnings, since
<string> shouldn't be used in most of PDFium, excepting tests, samples, js
bindings, etc.

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py#newcode22
PRESUBMIT.py:22: # Need to fix pdfium:426
I thought you fixed this.  Does this go away when you rebase?

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py#newcode30
PRESUBMIT.py:30: # Lots of non const references need to be fixed
nit: A truly picky person would say "non-const" but I'm not that guy.

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py#newcode32
PRESUBMIT.py:32: # Need to fix thread-unsafe methods to enable this.
Actually, we can't support threads, so we don't care.  Maybe update comment here
to reflect that.

https://codereview.chromium.org/1773733002/diff/1/core/include/fpdfapi/fpdf_o...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/1773733002/diff/1/core/include/fpdfapi/fpdf_o...
core/include/fpdfapi/fpdf_objects.h:12: #include <string>
Nah, std::string isn't used in pdfium, and this is a cpplint.py parser
shortcoming that it thinks we need it.  Maybe change the variable name "string"
in a few places until pylint shuts up ...

https://codereview.chromium.org/1773733002/diff/1/core/include/fxge/fx_ge.h
File core/include/fxge/fx_ge.h (right):

https://codereview.chromium.org/1773733002/diff/1/core/include/fxge/fx_ge.h#n...
core/include/fxge/fx_ge.h:10: #include <string>
ditto

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp:12: #include <string>
ditto

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp:8: #include
<string>
Okay, because its a test.

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.cpp
File core/src/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:7: #include <vector>
Hmm.  What does this fix?

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:389: // TODO(dsinclair): Should this be snprintf?
you mean strncpy?

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_tagged...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:8: #include <vector>
I saw the std::map usage, but didn't see the std::vector usage.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_bst...
File core/src/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_bst...
core/src/fxcrt/fx_basic_bstring.cpp:10: #include <string>
There aren't any std::strings in the core PDFium code.  Variable rename?

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_gcc...
File core/src/fxcrt/fx_basic_gcc.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_gcc...
core/src/fxcrt/fx_basic_gcc.cpp:10: #include <string>
ditto

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_wst...
File core/src/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_wst...
core/src/fxcrt/fx_basic_wstring.cpp:11: #include <string>
ditto

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
File core/src/fxge/win32/fx_win32_gdipext.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
core/src/fxge/win32/fx_win32_gdipext.cpp:20: #include <string>
ditto

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
File core/src/fxge/win32/fx_win32_print.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
core/src/fxge/win32/fx_win32_print.cpp:13: #include <string>
ditto

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/win32_i...
File core/src/fxge/win32/win32_int.h (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/win32_i...
core/src/fxge/win32/win32_int.h:10: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fx_systemha...
File fpdfsdk/include/fx_systemhandler.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fx_systemha...
fpdfsdk/include/fx_systemhandler.h:10: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fx_e...
File fpdfsdk/include/fxedit/fx_edit.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fx_e...
fpdfsdk/include/fxedit/fx_edit.h:10: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fxet...
File fpdfsdk/include/fxedit/fxet_list.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fxet...
fpdfsdk/include/fxedit/fxet_list.h:10: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/jsapi/fxjs_...
File fpdfsdk/include/jsapi/fxjs_v8.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/jsapi/fxjs_...
fpdfsdk/include/jsapi/fxjs_v8.h:20: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
File fpdfsdk/include/pdfwindow/PWL_ComboBox.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
fpdfsdk/include/pdfwindow/PWL_ComboBox.h:10: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
File fpdfsdk/include/pdfwindow/PWL_ListBox.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
fpdfsdk/include/pdfwindow/PWL_ListBox.h:10: #include <string>
*

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:1192: // http or ftp
Nit: HTTP or FTP since they are initials.

https://codereview.chromium.org/1773733002/diff/1/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1773733002/diff/1/public/fpdf_formfill.h#newc...
public/fpdf_formfill.h:580: FPDF_PAGE   (*FFI_GetPage)(struct
_FPDF_FORMFILLINFO* pThis,
excessive whitespace before first "(" on all of these

https://codereview.chromium.org/1773733002/diff/1/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/1773733002/diff/1/public/fpdfview.h#newcode18
public/fpdfview.h:18: #define PDF_USE_XFA
This might be a good place for a comment about that defining PDF_ENABLE_XFA
means "enable XFA if you can, since some old versions might not be able to do
so".  PDF_USE_XFA is a confirmation in response that it was able to do so.  Hmm.

// PDF_USE_XFA is set in confirmation that this version of PDFium can support
// XFA forms as requested by the PDF_ENABLE_XFA setting.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fgas/src/crt/fx_alg...
File xfa/src/fgas/src/crt/fx_algorithm.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fgas/src/crt/fx_alg...
xfa/src/fgas/src/crt/fx_algorithm.cpp:303: };
nit: stray semicolon here.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/common/BC...
File xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/common/BC...
xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h:41: static const int32_t
INIT_SIZE;
If possible, these really deserve an initializer here rather than in the .cpp
file.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/datamatri...
File xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/datamatri...
xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h:74: static const int32_t
INTEGERS[5];
nit: maybe put first in private section, followed by blank line.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OneDReader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OneDReader.h:34: static const int32_t
INTEGER_MATH_SHIFT;
ditto with initializers.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OneDimReader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OneDimReader.h:17: static const int32_t
MAX_AVG_VARIANCE;
initializers here (since they are scalars) if possible.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OneDimReader.h:23: static const int32_t
START_END_PATTERN[3];
no initializers here since they are arrays.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h:27: static const FX_CHAR*
ALPHABET_STRING;
can these be private?  Same issues.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h:21: static const int32_t
MAX_AVG_VARIANCE;
etc.

[dsinclair, 2016-03-08 21:08:03]

PTAL.

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py#newcode22
PRESUBMIT.py:22: # Need to fix pdfium:426
On 2016/03/08 19:27:04, Tom Sepez wrote:
> I thought you fixed this.  Does this go away when you rebase?

Done.

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py#newcode30
PRESUBMIT.py:30: # Lots of non const references need to be fixed
On 2016/03/08 19:27:04, Tom Sepez wrote:
> nit: A truly picky person would say "non-const" but I'm not that guy.

Done.

https://codereview.chromium.org/1773733002/diff/1/PRESUBMIT.py#newcode32
PRESUBMIT.py:32: # Need to fix thread-unsafe methods to enable this.
On 2016/03/08 19:27:04, Tom Sepez wrote:
> Actually, we can't support threads, so we don't care.  Maybe update comment
here
> to reflect that.

Done.

https://codereview.chromium.org/1773733002/diff/1/core/include/fpdfapi/fpdf_o...
File core/include/fpdfapi/fpdf_objects.h (right):

https://codereview.chromium.org/1773733002/diff/1/core/include/fpdfapi/fpdf_o...
core/include/fpdfapi/fpdf_objects.h:12: #include <string>
On 2016/03/08 19:27:04, Tom Sepez wrote:
> Nah, std::string isn't used in pdfium, and this is a cpplint.py parser
> shortcoming that it thinks we need it.  Maybe change the variable name
"string"
> in a few places until pylint shuts up ...

Done.

https://codereview.chromium.org/1773733002/diff/1/core/include/fxge/fx_ge.h
File core/include/fxge/fx_ge.h (right):

https://codereview.chromium.org/1773733002/diff/1/core/include/fxge/fx_ge.h#n...
core/include/fxge/fx_ge.h:10: #include <string>
On 2016/03/08 19:27:04, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp:12: #include <string>
On 2016/03/08 19:27:04, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects_unittest.cpp:8: #include
<string>
On 2016/03/08 19:27:04, Tom Sepez wrote:
> Okay, because its a test.

Acknowledged.

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.cpp
File core/src/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:7: #include <vector>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> Hmm.  What does this fix?

bool CPDF_InterForm::ResetForm(const std::vector<CPDF_FormField*>& fields,
                               bool bIncludeOrExclude,
                               bool bNotify) {

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:389: // TODO(dsinclair): Should this be snprintf?
On 2016/03/08 19:27:04, Tom Sepez wrote:
> you mean strncpy?

Was going by:

core/src/fpdfdoc/doc_form.cpp:390:  Almost always, snprintf is better than
strcpy  [runtime/printf] [4]


Changed to strncpy.

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_tagged...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:8: #include <vector>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> I saw the std::map usage, but didn't see the std::vector usage.

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_bst...
File core/src/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_bst...
core/src/fxcrt/fx_basic_bstring.cpp:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> There aren't any std::strings in the core PDFium code.  Variable rename?

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_gcc...
File core/src/fxcrt/fx_basic_gcc.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_gcc...
core/src/fxcrt/fx_basic_gcc.cpp:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_wst...
File core/src/fxcrt/fx_basic_wstring.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxcrt/fx_basic_wst...
core/src/fxcrt/fx_basic_wstring.cpp:11: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
File core/src/fxge/win32/fx_win32_gdipext.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
core/src/fxge/win32/fx_win32_gdipext.cpp:20: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
File core/src/fxge/win32/fx_win32_print.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/fx_win3...
core/src/fxge/win32/fx_win32_print.cpp:13: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/win32_i...
File core/src/fxge/win32/win32_int.h (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fxge/win32/win32_i...
core/src/fxge/win32/win32_int.h:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fx_systemha...
File fpdfsdk/include/fx_systemhandler.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fx_systemha...
fpdfsdk/include/fx_systemhandler.h:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fx_e...
File fpdfsdk/include/fxedit/fx_edit.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fx_e...
fpdfsdk/include/fxedit/fx_edit.h:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fxet...
File fpdfsdk/include/fxedit/fxet_list.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/fxedit/fxet...
fpdfsdk/include/fxedit/fxet_list.h:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/jsapi/fxjs_...
File fpdfsdk/include/jsapi/fxjs_v8.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/jsapi/fxjs_...
fpdfsdk/include/jsapi/fxjs_v8.h:20: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
File fpdfsdk/include/pdfwindow/PWL_ComboBox.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
fpdfsdk/include/pdfwindow/PWL_ComboBox.h:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
File fpdfsdk/include/pdfwindow/PWL_ListBox.h (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/include/pdfwindow/P...
fpdfsdk/include/pdfwindow/PWL_ListBox.h:10: #include <string>
On 2016/03/08 19:27:05, Tom Sepez wrote:
> *

Done.

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:1192: // http or ftp
On 2016/03/08 19:27:05, Tom Sepez wrote:
> Nit: HTTP or FTP since they are initials.

Done.

https://codereview.chromium.org/1773733002/diff/1/public/fpdf_formfill.h
File public/fpdf_formfill.h (right):

https://codereview.chromium.org/1773733002/diff/1/public/fpdf_formfill.h#newc...
public/fpdf_formfill.h:580: FPDF_PAGE   (*FFI_GetPage)(struct
_FPDF_FORMFILLINFO* pThis,
On 2016/03/08 19:27:05, Tom Sepez wrote:
> excessive whitespace before first "(" on all of these

Done.

https://codereview.chromium.org/1773733002/diff/1/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/1773733002/diff/1/public/fpdfview.h#newcode18
public/fpdfview.h:18: #define PDF_USE_XFA
On 2016/03/08 19:27:05, Tom Sepez wrote:
> This might be a good place for a comment about that defining PDF_ENABLE_XFA
> means "enable XFA if you can, since some old versions might not be able to do
> so".  PDF_USE_XFA is a confirmation in response that it was able to do so. 
Hmm.
> 
> // PDF_USE_XFA is set in confirmation that this version of PDFium can support
> // XFA forms as requested by the PDF_ENABLE_XFA setting.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fgas/src/crt/fx_alg...
File xfa/src/fgas/src/crt/fx_algorithm.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fgas/src/crt/fx_alg...
xfa/src/fgas/src/crt/fx_algorithm.cpp:303: };
On 2016/03/08 19:27:05, Tom Sepez wrote:
> nit: stray semicolon here.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/common/BC...
File xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/common/BC...
xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h:41: static const int32_t
INIT_SIZE;
On 2016/03/08 19:27:05, Tom Sepez wrote:
> If possible, these really deserve an initializer here rather than in the .cpp
> file.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/datamatri...
File xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/datamatri...
xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h:74: static const int32_t
INTEGERS[5];
On 2016/03/08 19:27:05, Tom Sepez wrote:
> nit: maybe put first in private section, followed by blank line.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OneDReader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OneDReader.h:34: static const int32_t
INTEGER_MATH_SHIFT;
On 2016/03/08 19:27:05, Tom Sepez wrote:
> ditto with initializers.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OneDimReader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OneDimReader.h:17: static const int32_t
MAX_AVG_VARIANCE;
On 2016/03/08 19:27:06, Tom Sepez wrote:
> initializers here (since they are scalars) if possible.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OneDimReader.h:23: static const int32_t
START_END_PATTERN[3];
On 2016/03/08 19:27:06, Tom Sepez wrote:
> no initializers here since they are arrays.

Acknowledged.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h:27: static const FX_CHAR*
ALPHABET_STRING;
On 2016/03/08 19:27:06, Tom Sepez wrote:
> can these be private?  Same issues.

Done.

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
File xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h (right):

https://codereview.chromium.org/1773733002/diff/1/xfa/src/fxbarcode/oned/BC_O...
xfa/src/fxbarcode/oned/BC_OnedCode128Reader.h:21: static const int32_t
MAX_AVG_VARIANCE;
On 2016/03/08 19:27:06, Tom Sepez wrote:
> etc.

Done.

[Tom Sepez, 2016-03-08 21:18:09]

lgtm

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.cpp
File core/src/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/1773733002/diff/1/core/src/fpdfdoc/doc_form.c...
core/src/fpdfdoc/doc_form.cpp:7: #include <vector>
On 2016/03/08 21:08:01, dsinclair wrote:
> On 2016/03/08 19:27:05, Tom Sepez wrote:
> > Hmm.  What does this fix?
> 
> bool CPDF_InterForm::ResetForm(const std::vector<CPDF_FormField*>& fields,
>                                bool bIncludeOrExclude,
>                                bool bNotify) {

Acknowledged.

[dsinclair, 2016-03-09 14:59:28]

Description was changed from

==========
Review and cleanup lint warnings.

This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.
==========

to

==========
Review and cleanup lint warnings.

This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/3ebd121d45ceb08918a3dcb5b3b7ac29448c...
==========

[dsinclair, 2016-03-09 14:59:29]

Committed patchset #5 (id:20002) manually as
3ebd121d45ceb08918a3dcb5b3b7ac29448c862f (presubmit successful).