Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Side by Side Diff: fpdfsdk/src/fxedit/fxet_list.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/fsdk_mgr.cpp ('k') | fpdfsdk/src/javascript/Document.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/fxedit/fxet_list.h"
8
7 #include "fpdfsdk/include/fxedit/fxet_edit.h" 9 #include "fpdfsdk/include/fxedit/fxet_edit.h"
8 #include "fpdfsdk/include/fxedit/fxet_list.h"
9 10
10 CFX_ListItem::CFX_ListItem() 11 CFX_ListItem::CFX_ListItem()
11 : m_pEdit(NULL), 12 : m_pEdit(NULL),
12 m_bSelected(FALSE), 13 m_bSelected(FALSE),
13 m_bCaret(FALSE), 14 m_bCaret(FALSE),
14 m_rcListItem(0.0f, 0.0f, 0.0f, 0.0f) { 15 m_rcListItem(0.0f, 0.0f, 0.0f, 0.0f) {
15 m_pEdit = IFX_Edit::NewEdit(); 16 m_pEdit = IFX_Edit::NewEdit();
16 m_pEdit->SetAlignmentV(1); 17 m_pEdit->SetAlignmentV(1);
17 m_pEdit->Initialize(); 18 m_pEdit->Initialize();
18 } 19 }
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 m_ptScrollPos.x = rect.left; 586 m_ptScrollPos.x = rect.left;
586 SetScrollPos(CFX_FloatPoint(rect.left, rect.top)); 587 SetScrollPos(CFX_FloatPoint(rect.left, rect.top));
587 ReArrange(0); 588 ReArrange(0);
588 InvalidateItem(-1); 589 InvalidateItem(-1);
589 } 590 }
590 591
591 CFX_FloatRect CFX_ListCtrl::GetItemRect(int32_t nIndex) const { 592 CFX_FloatRect CFX_ListCtrl::GetItemRect(int32_t nIndex) const {
592 return InToOut(CFX_List::GetItemRect(nIndex)); 593 return InToOut(CFX_List::GetItemRect(nIndex));
593 } 594 }
594 595
595 void CFX_ListCtrl::AddString(const FX_WCHAR* string) { 596 void CFX_ListCtrl::AddString(const FX_WCHAR* str) {
596 AddItem(string); 597 AddItem(str);
597 ReArrange(GetCount() - 1); 598 ReArrange(GetCount() - 1);
598 } 599 }
599 600
600 void CFX_ListCtrl::SetMultipleSelect(int32_t nItemIndex, FX_BOOL bSelected) { 601 void CFX_ListCtrl::SetMultipleSelect(int32_t nItemIndex, FX_BOOL bSelected) {
601 if (!IsValid(nItemIndex)) 602 if (!IsValid(nItemIndex))
602 return; 603 return;
603 604
604 if (bSelected != IsItemSelected(nItemIndex)) { 605 if (bSelected != IsItemSelected(nItemIndex)) {
605 if (bSelected) { 606 if (bSelected) {
606 SetItemSelect(nItemIndex, TRUE); 607 SetItemSelect(nItemIndex, TRUE);
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 813
813 int32_t CFX_ListCtrl::GetItemIndex(const CFX_FloatPoint& point) const { 814 int32_t CFX_ListCtrl::GetItemIndex(const CFX_FloatPoint& point) const {
814 return CFX_List::GetItemIndex(OutToIn(point)); 815 return CFX_List::GetItemIndex(OutToIn(point));
815 } 816 }
816 817
817 CFX_WideString CFX_ListCtrl::GetText() const { 818 CFX_WideString CFX_ListCtrl::GetText() const {
818 if (IsMultipleSel()) 819 if (IsMultipleSel())
819 return GetItemText(m_nCaretIndex); 820 return GetItemText(m_nCaretIndex);
820 return GetItemText(m_nSelItem); 821 return GetItemText(m_nSelItem);
821 } 822 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/fsdk_mgr.cpp ('k') | fpdfsdk/src/javascript/Document.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698