xfa/src/fxbarcode/oned/BC_OneDReader.h - Issue 1773733002: Review and cleanup lint warnings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/src/fxbarcode/oned/BC_OneDReader.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h ('K') | « xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h ('k') | xfa/src/fxbarcode/oned/BC_OneDimReader.h » ('j') | xfa/src/fxbarcode/oned/BC_OneDimReader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_SRC_FXBARCODE_ONED_BC_ONEDREADER_H_	7 #ifndef XFA_SRC_FXBARCODE_ONED_BC_ONEDREADER_H_

8 #define XFA_SRC_FXBARCODE_ONED_BC_ONEDREADER_H_	8 #define XFA_SRC_FXBARCODE_ONED_BC_ONEDREADER_H_

9	9

10 #include "xfa/src/fxbarcode/BC_Reader.h"	10 #include "xfa/src/fxbarcode/BC_Reader.h"

(...skipping 13 matching lines...) Expand all Loading...
24 CBC_CommonBitArray* row,	24 CBC_CommonBitArray* row,

25 int32_t hints,	25 int32_t hints,

26 int32_t& e) {	26 int32_t& e) {

27 return "";	27 return "";

28 }	28 }

29	29

30 private:	30 private:

31 CFX_ByteString DeDecode(CBC_BinaryBitmap* image, int32_t hints, int32_t& e);	31 CFX_ByteString DeDecode(CBC_BinaryBitmap* image, int32_t hints, int32_t& e);

32	32

33 protected:	33 protected:

34 const static int32_t INTEGER_MATH_SHIFT;	34 static const int32_t INTEGER_MATH_SHIFT;
	Tom Sepez 2016/03/08 19:27:05 ditto with initializers. ditto with initializers. dsinclair 2016/03/08 21:08:02 Done. Show quoted text On 2016/03/08 19:27:05, Tom Sepez wrote: > ditto with initializers. Done.
35 const static int32_t PATTERN_MATCH_RESULT_SCALE_FACTOR;	35 static const int32_t PATTERN_MATCH_RESULT_SCALE_FACTOR;

36 void RecordPattern(CBC_CommonBitArray* row,	36 void RecordPattern(CBC_CommonBitArray* row,

37 int32_t start,	37 int32_t start,

38 CFX_Int32Array* counters,	38 CFX_Int32Array* counters,

39 int32_t& e);	39 int32_t& e);

40 void RecordPatternInReverse(CBC_CommonBitArray* row,	40 void RecordPatternInReverse(CBC_CommonBitArray* row,

41 int32_t start,	41 int32_t start,

42 CFX_Int32Array* counters,	42 CFX_Int32Array* counters,

43 int32_t& e);	43 int32_t& e);

44 int32_t PatternMatchVariance(CFX_Int32Array* counters,	44 int32_t PatternMatchVariance(CFX_Int32Array* counters,

45 const int32_t* pattern,	45 const int32_t* pattern,

46 int32_t maxIndividualVariance);	46 int32_t maxIndividualVariance);

47 };	47 };

48	48

49 #endif // XFA_SRC_FXBARCODE_ONED_BC_ONEDREADER_H_	49 #endif // XFA_SRC_FXBARCODE_ONED_BC_ONEDREADER_H_

OLD	NEW