Review and cleanup lint warnings.

core/src/fpdfdoc/doc_form.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
+#include <vector>

[Tom Sepez, 2016/03/08 19:27:05]

Hmm.  What does this fix?

[dsinclair, 2016/03/08 21:08:01]

bool CPDF_InterForm::ResetForm(const std::vector<CPDF_FormField*>& fields,
                               bool bIncludeOrExclude,
                               bool bNotify) {

[Tom Sepez, 2016/03/08 21:18:09]

Acknowledged.

+
 #include "core/include/fpdfdoc/fpdf_doc.h"
 #include "core/src/fpdfdoc/doc_utils.h"
 #include "third_party/base/stl_util.h"
 
 namespace {
 
 const int nMaxRecursion = 32;
 
 const struct SupportFieldEncoding {
   const FX_CHAR* m_name;
@@ skipping 360 matching lines @@
   return fd.bFind;
 }
 static FX_BOOL RetrieveSpecificFont(uint8_t charSet,
                                     uint8_t pitchAndFamily,
                                     LPCSTR pcsFontName,
                                     LOGFONTA& lf) {
   memset(&lf, 0, sizeof(LOGFONTA));
   lf.lfCharSet = charSet;
   lf.lfPitchAndFamily = pitchAndFamily;
   if (pcsFontName) {
+    // TODO(dsinclair): Should this be snprintf?

[Tom Sepez, 2016/03/08 19:27:04]

you mean strncpy?

[dsinclair, 2016/03/08 21:08:01]

Was going by:

core/src/fpdfdoc/doc_form.cpp:390:  Almost always, snprintf is better than
strcpy  [runtime/printf] [4]


Changed to strncpy.

     strcpy(lf.lfFaceName, pcsFontName);
   }
   return RetrieveSpecificFont(lf);
 }
 #ifdef PDF_ENABLE_XFA
 static FX_BOOL RetrieveStockFont(int iFontObject,
                                  uint8_t charSet,
                                  LOGFONTA& lf) {
   HFONT hFont = (HFONT)::GetStockObject(iFontObject);
   if (hFont) {
@@ skipping 809 matching lines @@
     FDF_ImportField(pField, L"", bNotify);
   }
   if (bNotify && m_pFormNotify) {
     m_pFormNotify->AfterFormImportData(this);
   }
   return TRUE;
 }
 void CPDF_InterForm::SetFormNotify(const CPDF_FormNotify* pNotify) {
   m_pFormNotify = (CPDF_FormNotify*)pNotify;
 }