Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: fpdfsdk/src/pdfwindow/PWL_ListBox.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/pdfwindow/PWL_Edit.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Note.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/pdfwindow/PWL_ListBox.h" 7 #include "fpdfsdk/include/pdfwindow/PWL_ListBox.h"
8 8
9 #include "fpdfsdk/include/pdfwindow/PWL_Edit.h" 9 #include "fpdfsdk/include/pdfwindow/PWL_Edit.h"
10 #include "fpdfsdk/include/pdfwindow/PWL_EditCtrl.h" 10 #include "fpdfsdk/include/pdfwindow/PWL_EditCtrl.h"
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 CFX_FloatRect CPWL_ListBox::GetFocusRect() const { 384 CFX_FloatRect CPWL_ListBox::GetFocusRect() const {
385 if (m_pList && m_pList->IsMultipleSel()) { 385 if (m_pList && m_pList->IsMultipleSel()) {
386 CFX_FloatRect rcCaret = m_pList->GetItemRect(m_pList->GetCaret()); 386 CFX_FloatRect rcCaret = m_pList->GetItemRect(m_pList->GetCaret());
387 rcCaret.Intersect(GetClientRect()); 387 rcCaret.Intersect(GetClientRect());
388 return rcCaret; 388 return rcCaret;
389 } 389 }
390 390
391 return CPWL_Wnd::GetFocusRect(); 391 return CPWL_Wnd::GetFocusRect();
392 } 392 }
393 393
394 void CPWL_ListBox::AddString(const FX_WCHAR* string) { 394 void CPWL_ListBox::AddString(const FX_WCHAR* str) {
395 if (m_pList) { 395 if (m_pList) {
396 m_pList->AddString(string); 396 m_pList->AddString(str);
397 } 397 }
398 } 398 }
399 399
400 CFX_WideString CPWL_ListBox::GetText() const { 400 CFX_WideString CPWL_ListBox::GetText() const {
401 if (m_pList) 401 if (m_pList)
402 return m_pList->GetText(); 402 return m_pList->GetText();
403 403
404 return L""; 404 return L"";
405 } 405 }
406 406
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 if (zDelta < 0) { 524 if (zDelta < 0) {
525 m_pList->OnVK_DOWN(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag)); 525 m_pList->OnVK_DOWN(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag));
526 } else { 526 } else {
527 m_pList->OnVK_UP(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag)); 527 m_pList->OnVK_UP(IsSHIFTpressed(nFlag), IsCTRLpressed(nFlag));
528 } 528 }
529 529
530 FX_BOOL bExit = FALSE; 530 FX_BOOL bExit = FALSE;
531 OnNotifySelChanged(FALSE, bExit, nFlag); 531 OnNotifySelChanged(FALSE, bExit, nFlag);
532 return TRUE; 532 return TRUE;
533 } 533 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/pdfwindow/PWL_Edit.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Note.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698