core/src/fxcrt/fx_system_unittest.cpp - Issue 1773733002: Review and cleanup lint warnings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/src/fxcrt/fx_system_unittest.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « core/src/fxcrt/fx_basic_wstring.cpp ('k') | core/src/fxcrt/fx_xml_parser.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 PDFium Authors. All rights reserved.	1 // Copyright 2015 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include <limits>

5 #include <string>	6 #include <string>

6	7

7 #include "core/include/fxcrt/fx_system.h"	8 #include "core/include/fxcrt/fx_system.h"

8 #include "testing/fx_string_testhelpers.h"	9 #include "testing/fx_string_testhelpers.h"

9 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

10	11

11 // Unit test covering cases where PDFium replaces well-known library	12 // Unit test covering cases where PDFium replaces well-known library

12 // functionality on any given platformn.	13 // functionality on any given platformn.

13	14

14 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_	15 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_

(...skipping 137 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
152	153

153 Check64BitBase16Itoa(std::numeric_limits<int64_t>::max(), "7fffffffffffffff");	154 Check64BitBase16Itoa(std::numeric_limits<int64_t>::max(), "7fffffffffffffff");

154 Check64BitBase10Itoa(std::numeric_limits<int64_t>::max(),	155 Check64BitBase10Itoa(std::numeric_limits<int64_t>::max(),

155 "9223372036854775807");	156 "9223372036854775807");

156 Check64BitBase2Itoa(	157 Check64BitBase2Itoa(

157 std::numeric_limits<int64_t>::max(),	158 std::numeric_limits<int64_t>::max(),

158 "111111111111111111111111111111111111111111111111111111111111111");	159 "111111111111111111111111111111111111111111111111111111111111111");

159 }	160 }

160	161

161 #endif // _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_	162 #endif // _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_

OLD	NEW