Review and cleanup lint warnings.

core/src/fxcrt/fx_basic_gcc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include <cctype>
 #include <cwctype>
 #include <limits>
 
@@ skipping 15 matching lines @@
     if (num > (std::numeric_limits<IntType>::max() - val) / 10)
       break;
 
     num = num * 10 + val;
     str++;
   }
   return neg ? -num : num;
 }
 
 template <typename T, typename UT, typename STR_T>
-STR_T FXSYS_IntToStr(T value, STR_T string, int radix) {
+STR_T FXSYS_IntToStr(T value, STR_T str, int radix) {
   if (radix < 2 || radix > 16) {
-    string[0] = 0;
-    return string;
+    str[0] = 0;
+    return str;
   }
   if (value == 0) {
-    string[0] = '0';
-    string[1] = 0;
-    return string;
+    str[0] = '0';
+    str[1] = 0;
+    return str;
   }
   int i = 0;
   UT uvalue;
   if (value < 0) {
-    string[i++] = '-';
+    str[i++] = '-';
     // Standard trick to avoid undefined behaviour when negating INT_MIN.
     uvalue = static_cast<UT>(-(value + 1)) + 1;
   } else {
     uvalue = value;
   }
   int digits = 1;
   T order = uvalue / radix;
   while (order > 0) {
     digits++;
     order = order / radix;
   }
   for (int d = digits - 1; d > -1; d--) {
-    string[d + i] = "0123456789abcdef"[uvalue % radix];
+    str[d + i] = "0123456789abcdef"[uvalue % radix];
     uvalue /= radix;
   }
-  string[digits + i] = 0;
-  return string;
+  str[digits + i] = 0;
+  return str;
 }
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 int32_t FXSYS_atoi(const FX_CHAR* str) {
   return FXSYS_StrToInt<int32_t, FX_CHAR>(str);
 }
 uint32_t FXSYS_atoui(const FX_CHAR* str) {
   return FXSYS_StrToInt<uint32_t>(str);
@@ skipping 107 matching lines @@
   do {
     if (((f = (FX_WCHAR)(*(dst++))) >= 'A') && (f <= 'Z')) {
       f -= ('A' - 'a');
     }
     if (((l = (FX_WCHAR)(*(src++))) >= 'A') && (l <= 'Z')) {
       l -= ('A' - 'a');
     }
   } while (f && (f == l));
   return (f - l);
 }
-char* FXSYS_itoa(int value, char* string, int radix) {
-  return FXSYS_IntToStr<int32_t, uint32_t, FX_CHAR*>(value, string, radix);
+char* FXSYS_itoa(int value, char* str, int radix) {
+  return FXSYS_IntToStr<int32_t, uint32_t, FX_CHAR*>(value, str, radix);
 }
 #ifdef __cplusplus
 }
 #endif
 #endif
 #if _FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_
 #ifdef __cplusplus
 extern "C" {
 #endif
 int FXSYS_WideCharToMultiByte(FX_DWORD codepage,
@@ skipping 27 matching lines @@
       buf[wlen] = bstr[i];
     }
     wlen++;
   }
   return wlen;
 }
 #ifdef __cplusplus
 }
 #endif
 #endif