Review and cleanup lint warnings.

fpdfsdk/src/javascript/JS_Value.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/src/javascript/JS_Value.h"
 
 #include <time.h>
+
 #include <algorithm>
 #include <cmath>
 #include <limits>
+#include <vector>
 
 #include "fpdfsdk/src/javascript/Document.h"
 #include "fpdfsdk/src/javascript/JS_Define.h"
 #include "fpdfsdk/src/javascript/JS_Object.h"
 
 static const FX_DWORD g_nan[2] = {0, 0x7FF80000};
 static double GetNan() {
   return *(double*)g_nan;
 }
 
@@ skipping 331 matching lines @@
   ppObj = CJS_Value::ToV8Object();
 }
 
 void CJS_PropValue::StartSetting() {
   m_bIsSetting = 1;
 }
 
 void CJS_PropValue::StartGetting() {
   m_bIsSetting = 0;
 }
-void CJS_PropValue::operator<<(CFX_ByteString string) {
+void CJS_PropValue::operator<<(CFX_ByteString str) {
   ASSERT(!m_bIsSetting);
-  CJS_Value::operator=(string.c_str());
+  CJS_Value::operator=(str.c_str());
 }
 
-void CJS_PropValue::operator>>(CFX_ByteString& string) const {
+void CJS_PropValue::operator>>(CFX_ByteString& str) const {
   ASSERT(m_bIsSetting);
-  string = CJS_Value::ToCFXByteString();
+  str = CJS_Value::ToCFXByteString();
 }
 
 void CJS_PropValue::operator<<(const FX_WCHAR* c_string) {
   ASSERT(!m_bIsSetting);
   CJS_Value::operator=(c_string);
 }
 
 void CJS_PropValue::operator>>(CFX_WideString& wide_string) const {
   ASSERT(m_bIsSetting);
   wide_string = CJS_Value::ToCFXWideString();
@@ skipping 405 matching lines @@
 }
 
 int JS_GetMinFromTime(double dt) {
   return (int)_Mod(FXSYS_floor((double)(dt / (60 * 1000))), 60);
 }
 
 int JS_GetSecFromTime(double dt) {
   return (int)_Mod(FXSYS_floor((double)(dt / 1000)), 60);
 }
 
-double JS_DateParse(const wchar_t* string) {
+double JS_DateParse(const wchar_t* str) {
   v8::Isolate* pIsolate = v8::Isolate::GetCurrent();
   v8::Isolate::Scope isolate_scope(pIsolate);
   v8::HandleScope scope(pIsolate);
 
   v8::Local<v8::Context> context = pIsolate->GetCurrentContext();
 
   // Use the built-in object method.
   v8::Local<v8::Value> v =
       context->Global()
           ->Get(context, v8::String::NewFromUtf8(pIsolate, "Date",
                                                  v8::NewStringType::kNormal)
                              .ToLocalChecked())
           .ToLocalChecked();
   if (v->IsObject()) {
     v8::Local<v8::Object> o = v->ToObject(context).ToLocalChecked();
     v = o->Get(context, v8::String::NewFromUtf8(pIsolate, "parse",
                                                 v8::NewStringType::kNormal)
                             .ToLocalChecked()).ToLocalChecked();
     if (v->IsFunction()) {
       v8::Local<v8::Function> funC = v8::Local<v8::Function>::Cast(v);
 
       const int argc = 1;
-      v8::Local<v8::String> timeStr = FXJS_WSToJSString(pIsolate, string);
+      v8::Local<v8::String> timeStr = FXJS_WSToJSString(pIsolate, str);
       v8::Local<v8::Value> argv[argc] = {timeStr};
       v = funC->Call(context, context->Global(), argc, argv).ToLocalChecked();
       if (v->IsNumber()) {
         double date = v->ToNumber(context).ToLocalChecked()->Value();
         if (!_isfinite(date))
           return date;
         return date + _getLocalTZA() + _getDaylightSavingTA(date);
       }
     }
   }
@@ skipping 69 matching lines @@
   for (int i = 0; i < nKeywords; ++i) {
     const wchar_t* property = va_arg(ap, const wchar_t*);
     v8::Local<v8::Value> v8Value =
         FXJS_GetObjectElement(pRuntime->GetIsolate(), pObj, property);
     if (!v8Value->IsUndefined())
       result[i] = CJS_Value(pRuntime, v8Value, CJS_Value::VT_unknown);
   }
   va_end(ap);
   return result;
 }