Review and cleanup lint warnings.

public/fpdfview.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 // NOTE: External docs refer to this file as "fpdfview.h", so do not rename
 // despite lack of consistency with other public files.
 
 #ifndef PUBLIC_FPDFVIEW_H_
 #define PUBLIC_FPDFVIEW_H_
 
 #if defined(_WIN32) && !defined(__WINDOWS__)
 #include <windows.h>
 #endif
 
 #ifdef PDF_ENABLE_XFA
-// TODO: remove the #define when XFA is officially in pdfium
 #define PDF_USE_XFA

[Tom Sepez, 2016/03/08 19:27:05]

This might be a good place for a comment about that defining PDF_ENABLE_XFA
means "enable XFA if you can, since some old versions might not be able to do
so".  PDF_USE_XFA is a confirmation in response that it was able to do so.  Hmm.

// PDF_USE_XFA is set in confirmation that this version of PDFium can support
// XFA forms as requested by the PDF_ENABLE_XFA setting.

[dsinclair, 2016/03/08 21:08:02]

Done.

 #endif  // PDF_ENABLE_XFA
 
 // PDF types
 typedef void* FPDF_ACTION;
 typedef void* FPDF_BITMAP;
 typedef void* FPDF_BOOKMARK;
 typedef void* FPDF_CLIPPATH;
 typedef void* FPDF_DEST;
 typedef void* FPDF_DOCSCHHANDLE;
 typedef void* FPDF_DOCUMENT;
@@ skipping 276 matching lines @@
    * @param[in]   offset      Offset position starts from the beginning of file
    * stream. This parameter indicates reading position.
    * @param[in]   buffer      Memory buffer to store data which are read from
    * file stream. This parameter should not be <b>NULL</b>.
    * @param[in]   size        Size of data which should be read from file
    * stream, in bytes. The buffer indicated by the parameter <i>buffer</i>
    * should be enough to store specified data.
    *
    * @return 0 for success, other value for failure.
    */
-  FPDF_RESULT (*ReadBlock)(FPDF_LPVOID clientData, FPDF_DWORD offset, FPDF_LPVOID buffer, FPDF_DWORD size);
+  FPDF_RESULT (*ReadBlock)(FPDF_LPVOID clientData,
+                           FPDF_DWORD offset,
+                           FPDF_LPVOID buffer,
+                           FPDF_DWORD size);
   /**
    * @brief   Callback function to write data into the current file stream.
    *
    * @param[in]   clientData  Pointer to user-defined data.
    * @param[in]   offset      Offset position starts from the beginning of file
    * stream. This parameter indicates writing position.
    * @param[in]   buffer      Memory buffer contains data which is written into
    * file stream. This parameter should not be <b>NULL</b>.
    * @param[in]   size        Size of data which should be written into file
    * stream, in bytes.
    *
    * @return 0 for success, other value for failure.
    */
-  FPDF_RESULT (*WriteBlock)(FPDF_LPVOID clientData, FPDF_DWORD offset, FPDF_LPCVOID buffer, FPDF_DWORD size);
+  FPDF_RESULT (*WriteBlock)(FPDF_LPVOID clientData,
+                            FPDF_DWORD offset,
+                            FPDF_LPCVOID buffer,
+                            FPDF_DWORD size);
   /**
    * @brief   Callback function to flush all internal accessing buffers.
    *
    * @param[in]   clientData  Pointer to user-defined data.
    *
    * @return 0 for success, other value for failure.
    */
   FPDF_RESULT (*Flush)(FPDF_LPVOID clientData);
   /**
    * @brief   Callback function to change file size.
@@ skipping 590 matching lines @@
 // Function: FPDF_BStr_Clear
 //          Helper function to clear a byte string.
 DLLEXPORT FPDF_RESULT STDCALL FPDF_BStr_Clear(FPDF_BSTR* str);
 #endif  // PDF_ENABLE_XFA
 
 #ifdef __cplusplus
 }
 #endif
 
 #endif  // PUBLIC_FPDFVIEW_H_