Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: fpdfsdk/src/jsapi/fxjs_v8.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/javascript/util.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "fpdfsdk/include/jsapi/fxjs_v8.h" 7 #include "fpdfsdk/include/jsapi/fxjs_v8.h"
8 8
9 #include <vector>
10
9 #include "core/include/fxcrt/fx_basic.h" 11 #include "core/include/fxcrt/fx_basic.h"
10 12
11 const wchar_t kFXJSValueNameString[] = L"string"; 13 const wchar_t kFXJSValueNameString[] = L"string";
12 const wchar_t kFXJSValueNameNumber[] = L"number"; 14 const wchar_t kFXJSValueNameNumber[] = L"number";
13 const wchar_t kFXJSValueNameBoolean[] = L"boolean"; 15 const wchar_t kFXJSValueNameBoolean[] = L"boolean";
14 const wchar_t kFXJSValueNameDate[] = L"date"; 16 const wchar_t kFXJSValueNameDate[] = L"date";
15 const wchar_t kFXJSValueNameObject[] = L"object"; 17 const wchar_t kFXJSValueNameObject[] = L"object";
16 const wchar_t kFXJSValueNameFxobj[] = L"fxobj"; 18 const wchar_t kFXJSValueNameFxobj[] = L"fxobj";
17 const wchar_t kFXJSValueNameNull[] = L"null"; 19 const wchar_t kFXJSValueNameNull[] = L"null";
18 const wchar_t kFXJSValueNameUndefined[] = L"undefined"; 20 const wchar_t kFXJSValueNameUndefined[] = L"undefined";
(...skipping 719 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 return pObj->Clone(); 740 return pObj->Clone();
739 } 741 }
740 742
741 v8::Local<v8::Value> FXJS_NewObject2(v8::Isolate* pIsolate, 743 v8::Local<v8::Value> FXJS_NewObject2(v8::Isolate* pIsolate,
742 v8::Local<v8::Array> pObj) { 744 v8::Local<v8::Array> pObj) {
743 if (pObj.IsEmpty()) 745 if (pObj.IsEmpty())
744 return v8::Local<v8::Value>(); 746 return v8::Local<v8::Value>();
745 return pObj->Clone(); 747 return pObj->Clone();
746 } 748 }
747 749
748 v8::Local<v8::Value> FXJS_NewString(v8::Isolate* pIsolate, 750 v8::Local<v8::Value> FXJS_NewString(v8::Isolate* pIsolate, const wchar_t* str) {
749 const wchar_t* string) { 751 return FXJS_WSToJSString(pIsolate, str);
750 return FXJS_WSToJSString(pIsolate, string);
751 } 752 }
752 753
753 v8::Local<v8::Value> FXJS_NewNull() { 754 v8::Local<v8::Value> FXJS_NewNull() {
754 return v8::Local<v8::Value>(); 755 return v8::Local<v8::Value>();
755 } 756 }
756 757
757 v8::Local<v8::Value> FXJS_NewDate(v8::Isolate* pIsolate, double d) { 758 v8::Local<v8::Value> FXJS_NewDate(v8::Isolate* pIsolate, double d) {
758 return v8::Date::New(pIsolate->GetCurrentContext(), d).ToLocalChecked(); 759 return v8::Date::New(pIsolate->GetCurrentContext(), d).ToLocalChecked();
759 } 760 }
760 761
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 return v8::Local<v8::Array>(); 803 return v8::Local<v8::Array>();
803 v8::Local<v8::Context> context = pIsolate->GetCurrentContext(); 804 v8::Local<v8::Context> context = pIsolate->GetCurrentContext();
804 return v8::Local<v8::Array>::Cast(pValue->ToObject(context).ToLocalChecked()); 805 return v8::Local<v8::Array>::Cast(pValue->ToObject(context).ToLocalChecked());
805 } 806 }
806 807
807 void FXJS_ValueCopy(v8::Local<v8::Value>& pTo, v8::Local<v8::Value> pFrom) { 808 void FXJS_ValueCopy(v8::Local<v8::Value>& pTo, v8::Local<v8::Value> pFrom) {
808 pTo = pFrom; 809 pTo = pFrom;
809 } 810 }
810 811
811 812
OLDNEW
« no previous file with comments | « fpdfsdk/src/javascript/util.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698