Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: core/src/fxcrt/fx_basic_wstring.cpp

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include <stddef.h> // For offsetof(). 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <cctype> 10 #include <cctype>
11 #include <string>
Tom Sepez 2016/03/08 19:27:05 ditto
dsinclair 2016/03/08 21:08:02 Done.
11 12
12 #include "core/include/fxcrt/fx_basic.h" 13 #include "core/include/fxcrt/fx_basic.h"
13 #include "core/include/fxcrt/fx_ext.h" 14 #include "core/include/fxcrt/fx_ext.h"
14 #include "third_party/base/numerics/safe_math.h" 15 #include "third_party/base/numerics/safe_math.h"
15 16
16 namespace { 17 namespace {
17 18
18 #ifndef NDEBUG 19 #ifndef NDEBUG
19 bool IsValidCodePage(FX_WORD codepage) { 20 bool IsValidCodePage(FX_WORD codepage) {
20 switch (codepage) { 21 switch (codepage) {
(...skipping 1021 matching lines...) Expand 10 before | Expand all | Expand 10 after
1042 int dest_len = 1043 int dest_len =
1043 FXSYS_MultiByteToWideChar(codepage, 0, bstr, src_len, nullptr, 0); 1044 FXSYS_MultiByteToWideChar(codepage, 0, bstr, src_len, nullptr, 0);
1044 CFX_WideString wstr; 1045 CFX_WideString wstr;
1045 if (dest_len) { 1046 if (dest_len) {
1046 FX_WCHAR* dest_buf = wstr.GetBuffer(dest_len); 1047 FX_WCHAR* dest_buf = wstr.GetBuffer(dest_len);
1047 FXSYS_MultiByteToWideChar(codepage, 0, bstr, src_len, dest_buf, dest_len); 1048 FXSYS_MultiByteToWideChar(codepage, 0, bstr, src_len, dest_buf, dest_len);
1048 wstr.ReleaseBuffer(dest_len); 1049 wstr.ReleaseBuffer(dest_len);
1049 } 1050 }
1050 return wstr; 1051 return wstr;
1051 } 1052 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698