core/include/fpdfapi/fpdf_objects.h - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_objects.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_objects.h

diff --git a/core/include/fpdfapi/fpdf_objects.h b/core/include/fpdfapi/fpdf_objects.h

index 58d98e5436ff0e064d88211994480b38ac3f2b93..a6fa056e139c8382e55fb6ce96588fb2566dde43 100644

--- a/core/include/fpdfapi/fpdf_objects.h

+++ b/core/include/fpdfapi/fpdf_objects.h

@@ -337,7 +337,7 @@ class CPDF_Dictionary : public CPDF_Object {

// Set* functions invalidate iterators for the element with the key |key|.

void SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj);

void SetAtName(const CFX_ByteStringC& key, const CFX_ByteString& name);

- void SetAtString(const CFX_ByteStringC& key, const CFX_ByteString& string);

+ void SetAtString(const CFX_ByteStringC& key, const CFX_ByteString& str);

void SetAtInteger(const CFX_ByteStringC& key, int i);

void SetAtNumber(const CFX_ByteStringC& key, FX_FLOAT f);

void SetAtReference(const CFX_ByteStringC& key,

« no previous file with comments | « PRESUBMIT.py ('k') | core/include/fxcrt/fx_system.h » ('j') | no next file with comments »