xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h - Issue 1773733002: Review and cleanup lint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h

diff --git a/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h b/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h

index cbb47fb55465f5de4cc4f10e2340bf5183097666..49c136f4fd81b572307781b19d76c0cd99760d46 100644

--- a/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h

+++ b/xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h

@@ -24,13 +24,13 @@ class CBC_OnedCodaBarReader : public CBC_OneDReader {

CFX_Int32Array* FindAsteriskPattern(CBC_CommonBitArray* row, int32_t& e);

FX_BOOL ArrayContains(const FX_CHAR array[], FX_CHAR key);

FX_CHAR ToNarrowWidePattern(CFX_Int32Array* counter);

- static const FX_CHAR* ALPHABET_STRING;

- const static int32_t CHARACTER_ENCODINGS[22];

- const static int32_t minCharacterLength;

+ static const FX_CHAR* ALPHABET_STRING;

+ static const int32_t CHARACTER_ENCODINGS[22];

- const static FX_CHAR STARTEND_ENCODING[8];

+ private:

+ static const int32_t minCharacterLength = 3;

+ static const FX_CHAR STARTEND_ENCODING[8];

};

#endif // XFA_SRC_FXBARCODE_ONED_BC_ONEDCODABARREADER_H_