xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h - Issue 1773733002: Review and cleanup lint warnings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h

Issue 1773733002: Review and cleanup lint warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.h ('K') | « xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecodedBitStreamParser.h ('k') | xfa/src/fxbarcode/oned/BC_OneDReader.h » ('j') | xfa/src/fxbarcode/oned/BC_OneDReader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_SRC_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDETECTOR_H_	7 #ifndef XFA_SRC_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDETECTOR_H_

8 #define XFA_SRC_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDETECTOR_H_	8 #define XFA_SRC_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDETECTOR_H_

9	9

10 #include "core/include/fxcrt/fx_basic.h"	10 #include "core/include/fxcrt/fx_basic.h"

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 int32_t Distance(CBC_ResultPoint* a, CBC_ResultPoint* b);	64 int32_t Distance(CBC_ResultPoint* a, CBC_ResultPoint* b);

65 void Increment(CFX_MapPtrTemplate<CBC_ResultPoint*, int32_t>& table,	65 void Increment(CFX_MapPtrTemplate<CBC_ResultPoint*, int32_t>& table,

66 CBC_ResultPoint* key);	66 CBC_ResultPoint* key);

67 int32_t Round(FX_FLOAT d);	67 int32_t Round(FX_FLOAT d);

68 void OrderBestPatterns(CFX_PtrArray* patterns);	68 void OrderBestPatterns(CFX_PtrArray* patterns);

69 virtual void Init(int32_t& e);	69 virtual void Init(int32_t& e);

70	70

71 private:	71 private:

72 CBC_CommonBitMatrix* m_image;	72 CBC_CommonBitMatrix* m_image;

73 CBC_WhiteRectangleDetector* m_rectangleDetector;	73 CBC_WhiteRectangleDetector* m_rectangleDetector;

74 const static int32_t INTEGERS[5];	74 static const int32_t INTEGERS[5];
	Tom Sepez 2016/03/08 19:27:05 nit: maybe put first in private section, followed nit: maybe put first in private section, followed by blank line. dsinclair 2016/03/08 21:08:02 Done. Show quoted text On 2016/03/08 19:27:05, Tom Sepez wrote: > nit: maybe put first in private section, followed by blank line. Done.
75 };	75 };

76	76

77 #endif // XFA_SRC_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDETECTOR_H_	77 #endif // XFA_SRC_FXBARCODE_DATAMATRIX_BC_DATAMATRIXDETECTOR_H_

OLD	NEW