Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/141dbc132f8aa2588fad4cf50fbfd7a319234b61
Cr-Commit-Position: refs/heads/master@{#380755}

[Avi (use Gerrit), 2016-02-18 19:55:53]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 19:58:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/1

[Avi (use Gerrit), 2016-02-18 20:00:35]

avi@chromium.org changed reviewers:
+ creis@chromium.org, domenic@chromium.org, igrigorik@chromium.org

[commit-bot: I haz the power, 2016-02-18 21:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 21:10:54]

Dry run: This issue passed the CQ dry run.

[domenic, 2016-02-18 21:21:18]

lgtm

[palmer, 2016-02-18 21:29:49]

palmer@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2016-02-18 21:29:49]

lgtm

[Charlie Reis, 2016-02-18 21:37:13]

Yeah, we should do this.  LGTM.

Should we get someone from UX to approve the string to display?  It'll also need
translating, and we've missed the string freeze for M50 (Feb 12).  Is there a
way to get an exception or do we need to wait for the branch cut?

https://codereview.chromium.org/1714573002/diff/1/components/app_modal_string...
File components/app_modal_strings.grdp (right):

https://codereview.chromium.org/1714573002/diff/1/components/app_modal_string...
components/app_modal_strings.grdp:39: <message
name="IDS_BEFORERELOAD_MESSAGEBOX_MESSAGE" desc="Text shown as the message of
the 'before reload' dialog.">
nit: 'before unload' dialog for reloads.

(There's no beforereload event, which is what this sounds like.)

[Avi (use Gerrit), 2016-02-18 21:41:13]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-02-18 21:42:26]

Good points.

1. I'm in talks with UX.
2. If we can't push this until after the branch cut, then we can truncate this
dialog like with https://codereview.chromium.org/1711863004/, and land this
patch after the cut.

https://codereview.chromium.org/1714573002/diff/1/components/app_modal_string...
File components/app_modal_strings.grdp (right):

https://codereview.chromium.org/1714573002/diff/1/components/app_modal_string...
components/app_modal_strings.grdp:39: <message
name="IDS_BEFORERELOAD_MESSAGEBOX_MESSAGE" desc="Text shown as the message of
the 'before reload' dialog.">
On 2016/02/18 21:37:13, Charlie Reis wrote:
> nit: 'before unload' dialog for reloads.
> 
> (There's no beforereload event, which is what this sounds like.)

Done.

[commit-bot: I haz the power, 2016-02-18 21:42:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/20001

[esprehn, 2016-02-18 22:56:43]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-02-18 22:56:44]

Not lgtm, you're leaving behind all the plumbing in blink.

[Avi (use Gerrit), 2016-02-18 23:26:08]

On 2016/02/18 22:56:44, esprehn wrote:
> Not lgtm, you're leaving behind all the plumbing in blink.

Same argument that Chris made in the other CL, that this is a UX decision that
other embedders might want to make differently.

FYI I put this as an intent.
https://groups.google.com/a/chromium.org/d/msg/blink-dev/YIH8CoYVGSg/Di7TsljX...

[commit-bot: I haz the power, 2016-02-19 00:18:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 00:18:07]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-02-24 17:10:41]

Elliott—

The intent has the required 3 LGs, and I'd like to go forward with this CL.

Your objection is noted, but I want to leave the plumbing in so that if a
different content/ embedder wants to make a different decision about displaying
the message, they can.

WDYT?

[jochen (gone - plz use gerrit), 2016-02-24 18:51:48]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-02-24 18:51:48]

I'd leave the string in - we need the IPC anyways, and leaving the string in on
the content/blink level will give embedders more flexibility

[Avi (use Gerrit), 2016-02-24 21:14:26]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-02-24 21:14:33]

Description was changed from

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
==========

to

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-02-24 21:17:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/40001

[commit-bot: I haz the power, 2016-02-24 21:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-24 21:29:21]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Avi (use Gerrit), 2016-02-25 15:38:44]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 15:41:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/40001

[commit-bot: I haz the power, 2016-02-25 16:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:08:22]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Avi (use Gerrit), 2016-02-25 16:23:06]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 16:23:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/60001

[commit-bot: I haz the power, 2016-02-25 16:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 16:43:40]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2016-02-25 21:53:20]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2016-02-25 21:54:02]

Description was changed from

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Avi (use Gerrit), 2016-02-25 21:54:02]

avi@chromium.org changed reviewers:
+ mnaganov@chromium.org

[commit-bot: I haz the power, 2016-02-25 21:59:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/70001

[Avi (use Gerrit), 2016-02-25 22:29:32]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 22:33:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/90001

[commit-bot: I haz the power, 2016-02-25 23:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 23:17:22]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Avi (use Gerrit), 2016-02-25 23:53:21]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 00:03:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/110001

[commit-bot: I haz the power, 2016-02-26 01:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 01:18:23]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Avi (use Gerrit), 2016-02-26 21:39:52]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 21:42:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/130001

[commit-bot: I haz the power, 2016-02-26 22:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 22:24:30]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Avi (use Gerrit), 2016-02-29 19:17:25]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 19:17:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/150001

[commit-bot: I haz the power, 2016-02-29 20:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 20:50:11]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-02-29 20:53:24]

avi@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Avi (use Gerrit), 2016-02-29 20:53:25]

Please review.

Mikhail, android files
Jochen, components
Fady, guest_view
Elliott, please take another look at the gloriousness of all the removed code,
as you requested
Ilya, histograms

[Avi (use Gerrit), 2016-02-29 20:54:02]

avi@chromium.org changed reviewers:
+ ainslie@chromium.org

[Fady Samuel, 2016-02-29 20:54:51]

guest_view lgtm

[mnaganov (inactive), 2016-02-29 20:58:39]

android_webview LGTM

[esprehn, 2016-02-29 21:36:04]

lgtm, you're a hero among humans. :)

[jochen (gone - plz use gerrit), 2016-03-01 14:36:05]

lgtm

[Avi (use Gerrit), 2016-03-01 17:11:31]

avi@chromium.org changed reviewers:
+ isherman@chromium.org

[Avi (use Gerrit), 2016-03-01 17:11:33]

The _other_ Ilya, can you look at histograms?

😳

[Ilya Sherman, 2016-03-01 22:25:25]

histograms.xml lgtm

[Avi (use Gerrit), 2016-03-08 20:53:44]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 20:54:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/170001

[commit-bot: I haz the power, 2016-03-08 22:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 22:35:54]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-03-10 20:17:37]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 20:18:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/190001

[commit-bot: I haz the power, 2016-03-10 21:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:16:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-03-11 17:19:11]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-03-11 17:19:11]

The patchset sent to the CQ was uploaded after l-g-t-m from palmer@chromium.org,
creis@chromium.org, domenic@chromium.org, jochen@chromium.org,
esprehn@chromium.org, fsamuel@chromium.org, isherman@chromium.org,
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/1714573002/#ps230001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-11 17:19:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/230001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/230001

[commit-bot: I haz the power, 2016-03-11 17:23:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 17:23:33]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-03-11 17:31:22]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-03-11 17:31:23]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
esprehn@chromium.org, palmer@chromium.org, fsamuel@chromium.org,
creis@chromium.org, domenic@chromium.org, isherman@chromium.org,
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/1714573002/#ps250001
(title: "rebase again")

[commit-bot: I haz the power, 2016-03-11 17:32:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/250001

[commit-bot: I haz the power, 2016-03-11 18:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 18:29:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-03-11 19:48:57]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/250001

[commit-bot: I haz the power, 2016-03-11 21:27:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 21:27:28]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-03-11 21:33:11]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-03-11 21:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714573002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714573002/250001

[commit-bot: I haz the power, 2016-03-11 22:27:57]

Description was changed from

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-11 22:27:59]

Committed patchset #14 (id:250001)

[commit-bot: I haz the power, 2016-03-11 22:29:18]

Description was changed from

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove the ability of webpages to specify strings for the onbeforeunload dialog.

BUG=587940
TEST=as in bug
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/141dbc132f8aa2588fad4cf50fbfd7a319234b61
Cr-Commit-Position: refs/heads/master@{#380755}
==========

[commit-bot: I haz the power, 2016-03-11 22:29:20]

Patchset 14 (id:??) landed as
https://crrev.com/141dbc132f8aa2588fad4cf50fbfd7a319234b61
Cr-Commit-Position: refs/heads/master@{#380755}