content/browser/frame_host/render_frame_host_impl.cc - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index cb3560491fc7f1054df895b574726e8ab1406b7a..10615f42110f563377626bbb59613d51d09357ba 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1441,14 +1441,13 @@ void RenderFrameHostImpl::OnRunJavaScriptMessage(

void RenderFrameHostImpl::OnRunBeforeUnloadConfirm(

const GURL& frame_url,

- const base::string16& message,

bool is_reload,

IPC::Message* reply_msg) {

// While a JS beforeunload dialog is showing, tabs in the same process

// shouldn't process input events.

GetProcess()->SetIgnoreInputEvents(true);

render_view_host_->GetWidget()->StopHangMonitorTimeout();

- delegate_->RunBeforeUnloadConfirm(this, message, is_reload, reply_msg);

+ delegate_->RunBeforeUnloadConfirm(this, is_reload, reply_msg);

}

void RenderFrameHostImpl::OnTextSurroundingSelectionResponse(