Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 lineNumber, 392 lineNumber,
393 stackTrace); 393 stackTrace);
394 } 394 }
395 } 395 }
396 396
397 bool ChromeClientImpl::canOpenBeforeUnloadConfirmPanel() 397 bool ChromeClientImpl::canOpenBeforeUnloadConfirmPanel()
398 { 398 {
399 return !!m_webView->client(); 399 return !!m_webView->client();
400 } 400 }
401 401
402 bool ChromeClientImpl::openBeforeUnloadConfirmPanelDelegate(LocalFrame* frame, c onst String& message, bool isReload) 402 bool ChromeClientImpl::openBeforeUnloadConfirmPanelDelegate(LocalFrame* frame, b ool isReload)
403 { 403 {
404 notifyPopupOpeningObservers(); 404 notifyPopupOpeningObservers();
405 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame); 405 WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
406 return webframe->client() && webframe->client()->runModalBeforeUnloadDialog( isReload, message); 406 return webframe->client() && webframe->client()->runModalBeforeUnloadDialog( isReload);
407 } 407 }
408 408
409 void ChromeClientImpl::closeWindowSoon() 409 void ChromeClientImpl::closeWindowSoon()
410 { 410 {
411 // Make sure this Page can no longer be found by JS. 411 // Make sure this Page can no longer be found by JS.
412 m_webView->page()->willBeClosed(); 412 m_webView->page()->willBeClosed();
413 413
414 // Make sure that all loading is stopped. Ensures that JS stops executing! 414 // Make sure that all loading is stopped. Ensures that JS stops executing!
415 m_webView->mainFrame()->stopLoading(); 415 m_webView->mainFrame()->stopLoading();
416 416
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 if (m_webView->pageImportanceSignals()) 1058 if (m_webView->pageImportanceSignals())
1059 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript(); 1059 m_webView->pageImportanceSignals()->setIssuedNonGetFetchFromScript();
1060 } 1060 }
1061 1061
1062 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler() 1062 PassOwnPtr<WebFrameScheduler> ChromeClientImpl::createFrameScheduler()
1063 { 1063 {
1064 return m_webView->scheduler()->createFrameScheduler().release(); 1064 return m_webView->scheduler()->createFrameScheduler().release();
1065 } 1065 }
1066 1066
1067 } // namespace blink 1067 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698