android_webview/browser/aw_javascript_dialog_manager.h - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_javascript_dialog_manager.h

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_contents_client_bridge_base.h ('k') | android_webview/browser/aw_javascript_dialog_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_javascript_dialog_manager.h

diff --git a/android_webview/browser/aw_javascript_dialog_manager.h b/android_webview/browser/aw_javascript_dialog_manager.h

index e5b38150f3ff2ea34701f5ce9da782d83035e4e0..9d0bf4a2cfc86daa21dcdda9d5cb77d305085a5a 100644

--- a/android_webview/browser/aw_javascript_dialog_manager.h

+++ b/android_webview/browser/aw_javascript_dialog_manager.h

@@ -25,7 +25,6 @@ class AwJavaScriptDialogManager : public content::JavaScriptDialogManager {

const DialogClosedCallback& callback,

bool* did_suppress_message) override;

void RunBeforeUnloadDialog(content::WebContents* web_contents,

- const base::string16& message_text,

bool is_reload,

const DialogClosedCallback& callback) override;

void CancelActiveAndPendingDialogs(