content/renderer/render_frame_impl.h - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index f57b15943a5dc37237e812de9112dcfefcbc1d65..0d7a3fabc15ea251ec30aa17976476ce96258d90 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -522,8 +522,7 @@ class CONTENT_EXPORT RenderFrameImpl

bool runModalPromptDialog(const blink::WebString& message,

const blink::WebString& default_value,

blink::WebString* actual_value) override;

- bool runModalBeforeUnloadDialog(bool is_reload,

- const blink::WebString& message) override;

+ bool runModalBeforeUnloadDialog(bool is_reload) override;

void showContextMenu(const blink::WebContextMenuData& data) override;

void clearContextMenu() override;

void willSendRequest(blink::WebLocalFrame* frame,

« no previous file with comments | « content/public/browser/javascript_dialog_manager.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »