Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2512)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 69c7e94f1d7a9e265207307606bf58057d55c908..5ea20a241bde2b32b1bbd01d62a192c58657dd34 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3627,9 +3627,7 @@ bool RenderFrameImpl::runModalPromptDialog(
return ok;
}
-bool RenderFrameImpl::runModalBeforeUnloadDialog(
- bool is_reload,
- const blink::WebString& message) {
+bool RenderFrameImpl::runModalBeforeUnloadDialog(bool is_reload) {
// If we are swapping out, we have already run the beforeunload handler.
// TODO(creis): Fix OnSwapOut to clear the frame without running beforeunload
// at all, to avoid running it twice.
@@ -3647,7 +3645,7 @@ bool RenderFrameImpl::runModalBeforeUnloadDialog(
base::string16 ignored_result;
render_view()->SendAndRunNestedMessageLoop(
new FrameHostMsg_RunBeforeUnloadConfirm(
- routing_id_, frame_->document().url(), message, is_reload,
+ routing_id_, frame_->document().url(), is_reload,
&success, &ignored_result));
return success;
}
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698