extensions/browser/guest_view/web_view/javascript_dialog_helper.cc - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/javascript_dialog_helper.h ('k') | third_party/WebKit/LayoutTests/fast/events/before-unload-reloads-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

index 1ac3c848ac99cd8ab1b93c0fd500792e74498459..83f69d917aee6f3e0572a53197e467754e9b1f08 100644

--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

@@ -72,7 +72,6 @@ void JavaScriptDialogHelper::RunJavaScriptDialog(

void JavaScriptDialogHelper::RunBeforeUnloadDialog(

content::WebContents* web_contents,

- const base::string16& message_text,

bool is_reload,

const DialogClosedCallback& callback) {

// This is called if the guest has a beforeunload event handler.