third_party/WebKit/Source/core/loader/EmptyClients.h - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt ('k') | third_party/WebKit/Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/EmptyClients.h

diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.h b/third_party/WebKit/Source/core/loader/EmptyClients.h

index 23d0d3b9ac4871c2d8d992ce9d67cb7cead10389..5b9c4ff190e8b0cecdecb2e93d43c7bd8749ce3e 100644

--- a/third_party/WebKit/Source/core/loader/EmptyClients.h

+++ b/third_party/WebKit/Source/core/loader/EmptyClients.h

@@ -111,7 +111,7 @@ public:

void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, const String&, unsigned, const String&, const String&) override {}

bool canOpenBeforeUnloadConfirmPanel() override { return false; }

- bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, const String&, bool) override { return true; }

+ bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, bool) override { return true; }

void closeWindowSoon() override {}