Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_unittest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc
index b09d94569f9a4d9fc6f93997f4552b1493e891d4..f66c758dd559079e6e51fbad48c0e71ca0a62e72 100644
--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc
@@ -669,16 +669,16 @@ TEST_F(RenderFrameHostManagerTest, FilterMessagesWhileSwappedOut) {
// without showing an actual dialog.
MockRenderProcessHost* ntp_process_host = ntp_rfh->GetProcess();
ntp_process_host->sink().ClearMessages();
- const base::string16 msg = base::ASCIIToUTF16("Message");
bool result = false;
base::string16 unused;
FrameHostMsg_RunBeforeUnloadConfirm before_unload_msg(
- ntp_rfh->GetRoutingID(), kChromeURL, msg, false, &result, &unused);
+ ntp_rfh->GetRoutingID(), kChromeURL, false, &result, &unused);
EXPECT_TRUE(ntp_rfh->OnMessageReceived(before_unload_msg));
EXPECT_TRUE(ntp_process_host->sink().GetUniqueMessageMatching(IPC_REPLY_ID));
// Also test RunJavaScriptMessage.
ntp_process_host->sink().ClearMessages();
+ const base::string16 msg = base::ASCIIToUTF16("Message");
FrameHostMsg_RunJavaScriptMessage js_msg(
ntp_rfh->GetRoutingID(), msg, msg, kChromeURL,
JAVASCRIPT_MESSAGE_TYPE_CONFIRM, &result, &unused);
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698