content/browser/web_contents/web_contents_impl.cc - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 17e4875da9c03244cd432c0eb68f07a05241f8d9..00b41b81c0c9fe78ae513ce08b394f61232a71fe 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3878,7 +3878,6 @@ void WebContentsImpl::RunJavaScriptMessage(

void WebContentsImpl::RunBeforeUnloadConfirm(

RenderFrameHost* render_frame_host,

- const base::string16& message,

bool is_reload,

IPC::Message* reply_msg) {

RenderFrameHostImpl* rfhi =

@@ -3899,7 +3898,7 @@ void WebContentsImpl::RunBeforeUnloadConfirm(

is_showing_before_unload_dialog_ = true;

dialog_manager_ = delegate_->GetJavaScriptDialogManager(this);

dialog_manager_->RunBeforeUnloadDialog(

- this, message, is_reload,

+ this, is_reload,

base::Bind(&WebContentsImpl::OnDialogClosed, base::Unretained(this),

render_frame_host->GetProcess()->GetID(),

render_frame_host->GetRoutingID(), reply_msg,

« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | no next file with comments »