third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 5483e3070afc3ebb7bd1e2dcaa322dcae9ec201b..14b318ea42847e332f2a4b0c59a5acf7973f4f67 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -82,7 +82,7 @@ public:

const String& message, unsigned lineNumber,

const String& sourceID, const String& stackTrace) override;

bool canOpenBeforeUnloadConfirmPanel() override;

- bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, const String&, bool isReload) override;

+ bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, bool isReload) override;

void closeWindowSoon() override;

bool openJavaScriptAlertDelegate(LocalFrame*, const String&) override;

bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) override;

« no previous file with comments | « third_party/WebKit/Source/core/page/ChromeClient.cpp ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »