android_webview/browser/aw_contents_client_bridge_base.h - Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_contents_client_bridge_base.h

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_contents_client_bridge_base.h

diff --git a/android_webview/browser/aw_contents_client_bridge_base.h b/android_webview/browser/aw_contents_client_bridge_base.h

index 6ac592b9c2776f7b5d0dd89d2fa582bd4b3fa191..00598bae8b967809dfe79b2acc2dd354a64fd4d4 100644

--- a/android_webview/browser/aw_contents_client_bridge_base.h

+++ b/android_webview/browser/aw_contents_client_bridge_base.h

@@ -59,7 +59,6 @@ class AwContentsClientBridgeBase {

virtual void RunBeforeUnloadDialog(

const GURL& origin_url,

- const base::string16& message_text,

const content::JavaScriptDialogManager::DialogClosedCallback& callback)

= 0;

« no previous file with comments | « android_webview/DEPS ('k') | android_webview/browser/aw_javascript_dialog_manager.h » ('j') | no next file with comments »